Bug 94879 - Unify Number to StringImpl conversion
Summary: Unify Number to StringImpl conversion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 17:16 PDT by Benjamin Poulain
Modified: 2012-08-24 17:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (38.37 KB, patch)
2012-08-23 17:43 PDT, Benjamin Poulain 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-08-23 17:16:49 PDT 
Unify WTF::String::number() and UString::number() under one implementation.
Comment 1 Benjamin Poulain 2012-08-23 17:43:22 PDT 
Created attachment 160295 [details]
Patch
Comment 2 Geoffrey Garen 2012-08-24 16:20:23 PDT 
Comment on attachment 160295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160295&action=review

r=me

> Source/WTF/wtf/text/IntegerToStringConversion.cpp:51
> +    typename UnsignedIntegerTrait<SignedIntegerType>::Type workInteger;

To be more specific, let's call "workInteger" "unsignedInteger" instead.
Comment 3 Benjamin Poulain 2012-08-24 17:12:58 PDT 
Committed r126658: <http://trac.webkit.org/changeset/126658>