WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94879
Unify Number to StringImpl conversion
https://bugs.webkit.org/show_bug.cgi?id=94879
Summary
Unify Number to StringImpl conversion
Benjamin Poulain
Reported
2012-08-23 17:16:49 PDT
Unify WTF::String::number() and UString::number() under one implementation.
Attachments
Patch
(38.37 KB, patch)
2012-08-23 17:43 PDT
,
Benjamin Poulain
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2012-08-23 17:43:22 PDT
Created
attachment 160295
[details]
Patch
Geoffrey Garen
Comment 2
2012-08-24 16:20:23 PDT
Comment on
attachment 160295
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=160295&action=review
r=me
> Source/WTF/wtf/text/IntegerToStringConversion.cpp:51 > + typename UnsignedIntegerTrait<SignedIntegerType>::Type workInteger;
To be more specific, let's call "workInteger" "unsignedInteger" instead.
Benjamin Poulain
Comment 3
2012-08-24 17:12:58 PDT
Committed
r126658
: <
http://trac.webkit.org/changeset/126658
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug