Bug 94869 – REGRESSION (r124815): PDF in frame does not display any more

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

REGRESSION (r124815): PDF in frame does not display any more.

BuiltinPDFView needs to notify the plugincontroller that it initialized.

In radar as <rdar://problem/12063306>

[Brady Eidson]

Created attachment 160267 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 160267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160267&action=review

No test?.. <:-|

> Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345
> +    controller()->didInitializePlugin();

I'm wondering if this should be made async to match regular code path. Probably not.

[Brady Eidson]

(In reply to comment #2)
> (From update of attachment 160267 [details])
> 
> > Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345
> > +    controller()->didInitializePlugin();
> 
> I'm wondering if this should be made async to match regular code path. Probably not.

Probably not indeed.  The regular synchronous code path for netscape plugins already has to do this, for example.

Thanks for the review!

[Brady Eidson]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 160267 [details] [details])
> > 
> > > Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345
> > > +    controller()->didInitializePlugin();
> > 
> > I'm wondering if this should be made async to match regular code path. Probably not.
> 
And also, the async design is largely centered around out-of-process plugins.  We'll need BuiltinPDFView to be out of process first.  :)

[Brady Eidson]

http://trac.webkit.org/changeset/126490