Bug 94869 - REGRESSION (r124815): PDF in frame does not display any more
Summary: REGRESSION (r124815): PDF in frame does not display any more
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-08-23 15:40 PDT by Brady Eidson
Modified: 2012-08-23 15:50 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2012-08-23 15:42 PDT, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-08-23 15:40:42 PDT 
REGRESSION (r124815): PDF in frame does not display any more.

BuiltinPDFView needs to notify the plugincontroller that it initialized.

In radar as <rdar://problem/12063306>
Comment 1 Brady Eidson 2012-08-23 15:42:17 PDT 
Created attachment 160267 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-08-23 15:44:43 PDT 
Comment on attachment 160267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160267&action=review

No test?.. <:-|

> Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345
> +    controller()->didInitializePlugin();

I'm wondering if this should be made async to match regular code path. Probably not.
Comment 3 Brady Eidson 2012-08-23 15:47:40 PDT 
(In reply to comment #2)
> (From update of attachment 160267 [details])
> 
> > Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345
> > +    controller()->didInitializePlugin();
> 
> I'm wondering if this should be made async to match regular code path. Probably not.

Probably not indeed.  The regular synchronous code path for netscape plugins already has to do this, for example.

Thanks for the review!
Comment 4 Brady Eidson 2012-08-23 15:49:21 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 160267 [details] [details])
> > 
> > > Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345
> > > +    controller()->didInitializePlugin();
> > 
> > I'm wondering if this should be made async to match regular code path. Probably not.
> 
And also, the async design is largely centered around out-of-process plugins.  We'll need BuiltinPDFView to be out of process first.  :)
Comment 5 Brady Eidson 2012-08-23 15:50:13 PDT 
http://trac.webkit.org/changeset/126490