RESOLVED FIXED 94866
[chromium] Convert WebLayerTreeView interface into pure virtual 
https://bugs.webkit.org/show_bug.cgi?id=94866
Summary [chromium] Convert WebLayerTreeView interface into pure virtual
James Robinson
Reported 2012-08-23 15:28:09 PDT
[chromium] Convert WebLayerTreeView interface into pure virtual
Attachments
Patch (92.62 KB, patch)
2012-08-23 15:37 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (92.55 KB, patch)
2012-08-23 16:39 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (92.64 KB, patch)
2012-08-23 17:55 PDT, James Robinson 		enne: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-23 15:37:14 PDT
Created attachment 160266 [details] Patch
James Robinson
Comment 2 2012-08-23 16:39:09 PDT
Created attachment 160278 [details] Patch
WebKit Review Bot
Comment 3 2012-08-23 16:41:22 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 4 2012-08-23 16:44:37 PDT
Depends on https://chromiumcodereview.appspot.com/10873052 landing and rolling into Source/WebKit/chromium/DEPS
WebKit Review Bot
Comment 5 2012-08-23 17:06:32 PDT
Comment on attachment 160278 [details] Patch Attachment 160278 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13567893
James Robinson
Comment 6 2012-08-23 17:54:02 PDT
Error is: Last 500 characters of output: elease/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.o Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp: In constructor '<unnamed>::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest()': Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp:69: error: returning a value from a constructor make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.o] Error 1 make: *** Waiting for unfinished jobs.... that line is: ASSERT_TRUE(m_layerTreeView = adoptPtr(WebLayerTreeView::create(&m_layerTreeViewClient, *m_platformLayer, WebLayerTreeView::Settings()))); so I suspect the way that macro expands makes g++ unhappy. I'll just remove, the test fails in a pretty obvious way if this call fails.
James Robinson
Comment 7 2012-08-23 17:55:13 PDT
Created attachment 160298 [details] Patch
Adrienne Walker
Comment 8 2012-08-24 10:12:37 PDT
Comment on attachment 160298 [details] Patch R=me.
James Robinson
Comment 9 2012-08-24 16:46:37 PDT
Committed r126652: <http://trac.webkit.org/changeset/126652>
Note You need to log in before you can comment on or make changes to this bug.