Bug 94865 – [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Xianzhu Wang]

After patch of https://bugs.webkit.org/show_bug.cgi?id=94387, NRWT chromium-android can't detect crashes, but quickly prints many 'Unexpected EOF ...' when a test crashes until timeout, and will treat it a timeout. On Android we depend on read() return None to detect crashes, so when the test crashes, the process (adb shell) is still alive.

[Xianzhu Wang]

Created attachment 160271 [details]
Patch

[Adam Barth]

dpranke is your best reviewer here.

[Dirk Pranke]

Comment on attachment 160271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160271&action=review

Ah, I knew the android port depended on this somehow but I didn't connect the dots to realize that adb was still running. Sorry about that!

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:143
> +                                        universal_newlines=True, treat_no_data_as_crash=True)

why not just make this a method on the port class?

[Xianzhu Wang]

Created attachment 160449 [details]
Patch

[Xianzhu Wang]

Comment on attachment 160271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160271&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:143
>> +                                        universal_newlines=True, treat_no_data_as_crash=True)
> 
> why not just make this a method on the port class?

Done.

[WebKit Review Bot]

Comment on attachment 160449 [details]
Patch

Clearing flags on attachment: 160449

Committed r126607: <http://trac.webkit.org/changeset/126607>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.