Bug 94865 - [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
Summary: [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 15:18 PDT by Xianzhu Wang
Modified: 2012-08-24 11:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.44 KB, patch)
2012-08-23 16:00 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Patch (6.63 KB, patch)
2012-08-24 10:45 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-08-23 15:18:57 PDT 
After patch of https://bugs.webkit.org/show_bug.cgi?id=94387, NRWT chromium-android can't detect crashes, but quickly prints many 'Unexpected EOF ...' when a test crashes until timeout, and will treat it a timeout. On Android we depend on read() return None to detect crashes, so when the test crashes, the process (adb shell) is still alive.
Comment 1 Xianzhu Wang 2012-08-23 16:00:50 PDT 
Created attachment 160271 [details]
Patch
Comment 2 Adam Barth 2012-08-23 16:09:38 PDT 
dpranke is your best reviewer here.
Comment 3 Dirk Pranke 2012-08-23 21:10:49 PDT 
Comment on attachment 160271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160271&action=review

Ah, I knew the android port depended on this somehow but I didn't connect the dots to realize that adb was still running. Sorry about that!

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:143
> +                                        universal_newlines=True, treat_no_data_as_crash=True)

why not just make this a method on the port class?
Comment 4 Xianzhu Wang 2012-08-24 10:45:17 PDT 
Created attachment 160449 [details]
Patch
Comment 5 Xianzhu Wang 2012-08-24 10:46:05 PDT 
Comment on attachment 160271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160271&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:143
>> +                                        universal_newlines=True, treat_no_data_as_crash=True)
> 
> why not just make this a method on the port class?

Done.
Comment 6 WebKit Review Bot 2012-08-24 11:55:29 PDT 
Comment on attachment 160449 [details]
Patch

Clearing flags on attachment: 160449

Committed r126607: <http://trac.webkit.org/changeset/126607>
Comment 7 WebKit Review Bot 2012-08-24 11:55:32 PDT 
All reviewed patches have been landed.  Closing bug.