Bug 94859 - [chromium] Prevent scrollbar thumb size from changing during compositor zoom
Summary: [chromium] Prevent scrollbar thumb size from changing during compositor zoom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 14:43 PDT by Adrienne Walker
Modified: 2012-08-27 14:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (27.67 KB, patch)
2012-08-24 16:02 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Patch for landing (27.34 KB, patch)
2012-08-27 12:37 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-08-23 14:43:49 PDT 
[chromium] Prevent scrollbar thumb size from changing during compositor zoom
Comment 1 Adrienne Walker 2012-08-24 16:02:37 PDT 
Created attachment 160517 [details]
Patch
Comment 2 James Robinson 2012-08-24 18:51:54 PDT 
Comment on attachment 160517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160517&action=review

R=me. seems like the most reasonable solution to a not very reasonable problem

> Source/WebKit/chromium/ChangeLog:12
> +2012-08-23  Adrienne Walker  <enne@google.com>

you've got a double changelog somehow

> Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp:80
> +        return (pos < 1 && pos > 0) ? 1 : pos;

would you mind being a little about how you want the type conversion to happen on the return here? i.e. floorf() before the cast if floor is what we want?

> Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h:52
> +    CCScrollbarGeometryFixedThumb(PassOwnPtr<WebKit::WebScrollbarThemeGeometry>);

guess what!

> Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryStub.h:64
> +    CCScrollbarGeometryStub(PassOwnPtr<WebKit::WebScrollbarThemeGeometry>);

and again
Comment 3 Adrienne Walker 2012-08-27 12:37:50 PDT 
Created attachment 160778 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-08-27 13:48:35 PDT 
Comment on attachment 160778 [details]
Patch for landing

Clearing flags on attachment: 160778

Committed r126791: <http://trac.webkit.org/changeset/126791>
Comment 5 WebKit Review Bot 2012-08-27 13:48:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Adrienne Walker 2012-08-27 14:20:19 PDT 
Committed r126794: <http://trac.webkit.org/changeset/126794>