WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94839
[BlackBerry] Obsolete the in-region scroll codepath prior to BB10's
https://bugs.webkit.org/show_bug.cgi?id=94839
Summary
[BlackBerry] Obsolete the in-region scroll codepath prior to BB10's
Antonio Gomes
Reported
2012-08-23 13:34:38 PDT
PR #197775
Attachments
patch
(12.95 KB, patch)
2012-08-23 13:43 PDT
,
Antonio Gomes
staikos
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antonio Gomes
Comment 1
2012-08-23 13:43:26 PDT
Created
attachment 160232
[details]
patch
Rob Buis
Comment 2
2012-08-23 14:17:09 PDT
Comment on
attachment 160232
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=160232&action=review
LGTM.
> Source/WebKit/blackberry/Api/WebPage.cpp:1474 > return true;
The bool does not seem needed anymore. And in fact maybe WebPagePrivate::scrollBy can be removed, WebPage::scrollBy could just do the one-liner.
Antonio Gomes
Comment 3
2012-08-23 17:42:25 PDT
https://trac.webkit.org/changeset/126514
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug