Bug 94839 - [BlackBerry] Obsolete the in-region scroll codepath prior to BB10's
Summary: [BlackBerry] Obsolete the in-region scroll codepath prior to BB10's
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on: 94834
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-23 13:34 PDT by Antonio Gomes
Modified: 2012-08-23 17:42 PDT (History)
3 users (show)

See Also:

Attachments
patch (12.95 KB, patch)
2012-08-23 13:43 PDT, Antonio Gomes 		staikos: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-08-23 13:34:38 PDT 
PR #197775
Comment 1 Antonio Gomes 2012-08-23 13:43:26 PDT 
Created attachment 160232 [details]
patch
Comment 2 Rob Buis 2012-08-23 14:17:09 PDT 
Comment on attachment 160232 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160232&action=review

LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:1474
>      return true;

The bool does not seem needed anymore. And in fact maybe WebPagePrivate::scrollBy can be removed,  WebPage::scrollBy could just do the one-liner.
Comment 3 Antonio Gomes 2012-08-23 17:42:25 PDT 
https://trac.webkit.org/changeset/126514