Bug 94826 - Web Inspector: dblclick on Timeline overview no longer selects entire timeline range
Summary: Web Inspector: dblclick on Timeline overview no longer selects entire timelin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 10:13 PDT by Andrey Kosyakov
Modified: 2012-08-23 10:45 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.44 KB, patch)
2012-08-23 10:15 PDT, Andrey Kosyakov
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-08-23 10:13:15 PDT
0. Open WebInspector, switch to Timeline
1. Record a timeline
2. Double click on overview pane

EXPECTED: Overview selection window is set to entire timeline range
ACTUAL: A minimal interval is selected, as would be upon a single click

This was apparently regressed by r123313
Comment 1 Andrey Kosyakov 2012-08-23 10:15:32 PDT
Created attachment 160191 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-08-23 10:30:21 PDT
Comment on attachment 160191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160191&action=review

> Source/WebCore/inspector/front-end/UIUtils.js:69
> +    function onMouseOut()

WebInspector._mouseOutWhileDragging = function()... ?

> Source/WebCore/inspector/front-end/UIUtils.js:71
> +        targetDocument.removeEventListener("mouseout", onMouseOut, true);

I would extract removeEventListener and delete statement.
Comment 3 Andrey Kosyakov 2012-08-23 10:45:47 PDT
Committed r126445: <http://trac.webkit.org/changeset/126445>