Bug 94813 - MediaStream API: Add readyState functionality to RTCPeerConnection
Summary: MediaStream API: Add readyState functionality to RTCPeerConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 80589
  Show dependency tree / graph
 
Reported: 2012-08-23 07:33 PDT by Tommy Widenflycht
Modified: 2012-08-24 08:10 PDT (History)
12 users (show)

See Also:

Attachments
Patch (20.24 KB, patch)
2012-08-23 07:41 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (21.14 KB, patch)
2012-08-24 05:26 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-08-23 07:33:41 PDT 
This patch adds readyState functionality to RTCPeerConnection, together with related callbacks and methods.
Comment 1 Tommy Widenflycht 2012-08-23 07:41:33 PDT 
Created attachment 160160 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-23 07:44:12 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-08-23 10:23:06 PDT 
Comment on attachment 160160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160160&action=review

> Source/WebCore/platform/mediastream/RTCPeerConnectionHandlerClient.h:42
> +    virtual void didChangeReadyState(uint32_t state) = 0;

uint32_t -> ReadyState

Perhaps we need to move the ReadyState enum to a more general location so we can reference it here?
Comment 4 Adam Barth 2012-08-23 10:23:35 PDT 
Looks like you've got a compile error on GTK to work through as well.
Comment 5 Tommy Widenflycht 2012-08-24 05:26:49 PDT 
Created attachment 160402 [details]
Patch
Comment 6 Tommy Widenflycht 2012-08-24 05:27:23 PDT 
Fixed.

(In reply to comment #4)
> Looks like you've got a compile error on GTK to work through as well.
Comment 7 Tommy Widenflycht 2012-08-24 05:28:16 PDT 
Comment on attachment 160160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160160&action=review

>> Source/WebCore/platform/mediastream/RTCPeerConnectionHandlerClient.h:42
>> +    virtual void didChangeReadyState(uint32_t state) = 0;
> 
> uint32_t -> ReadyState
> 
> Perhaps we need to move the ReadyState enum to a more general location so we can reference it here?

Fixed by moving the ReadyState definition to this class.
Comment 8 WebKit Review Bot 2012-08-24 08:09:57 PDT 
Comment on attachment 160402 [details]
Patch

Clearing flags on attachment: 160402

Committed r126586: <http://trac.webkit.org/changeset/126586>
Comment 9 WebKit Review Bot 2012-08-24 08:10:02 PDT 
All reviewed patches have been landed.  Closing bug.