Bug 94785 - [V8] V8ScriptInstance is much more complicated than necessary
Summary: [V8] V8ScriptInstance is much more complicated than necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 00:41 PDT by Adam Barth
Modified: 2012-08-23 12:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.24 KB, patch)
2012-08-23 00:56 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (3.96 KB, patch)
2012-08-23 10:58 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-08-23 00:41:33 PDT
[V8] V8ScriptInstance is much more complicated than necessary
Comment 1 Adam Barth 2012-08-23 00:56:51 PDT
Created attachment 160106 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-23 00:58:15 PDT
I don't have enough context to review this.
Comment 3 Kentaro Hara 2012-08-23 01:52:26 PDT
Comment on attachment 160106 [details]
Patch

LGTM. Looks like you need to rebase the patch with TOT.
Comment 4 Adam Barth 2012-08-23 10:58:42 PDT
Created attachment 160196 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-08-23 12:16:23 PDT
Comment on attachment 160196 [details]
Patch for landing

Clearing flags on attachment: 160196

Committed r126465: <http://trac.webkit.org/changeset/126465>
Comment 6 WebKit Review Bot 2012-08-23 12:16:27 PDT
All reviewed patches have been landed.  Closing bug.