Bug 94784 - [V8] ScheduledAction is ugly and needs a cleanup
Summary: [V8] ScheduledAction is ugly and needs a cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 00:18 PDT by Adam Barth
Modified: 2012-08-23 10:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.65 KB, patch)
2012-08-23 00:19 PDT, Adam Barth
eric: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 (376.91 KB, application/zip)
2012-08-23 01:05 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-08-23 00:18:51 PDT
[V8] ScheduledAction is ugly and needs a cleanup
Comment 1 Adam Barth 2012-08-23 00:19:49 PDT
Created attachment 160099 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-23 00:30:22 PDT
Comment on attachment 160099 [details]
Patch

Looks OK.  You should wait for the cq/ews of course.
Comment 3 WebKit Review Bot 2012-08-23 01:05:24 PDT
Comment on attachment 160099 [details]
Patch

Attachment 160099 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13560600

New failing tests:
http/tests/cache/post-with-cached-subresources.php
Comment 4 WebKit Review Bot 2012-08-23 01:05:27 PDT
Created attachment 160107 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 5 Adam Barth 2012-08-23 10:50:53 PDT
Committed r126446: <http://trac.webkit.org/changeset/126446>