Bug 94768 - [V8] Move evaluate() from V8Proxy to ScriptController
Summary: [V8] Move evaluate() from V8Proxy to ScriptController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 85330
  Show dependency tree / graph
 
Reported: 2012-08-22 19:14 PDT by Kentaro Hara
Modified: 2012-08-22 20:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.60 KB, patch)
2012-08-22 19:19 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-22 19:14:45 PDT 
To kill V8Proxy, we can move evaluate() from V8Proxy to ScriptController.
Comment 1 Kentaro Hara 2012-08-22 19:19:10 PDT 
Created attachment 160067 [details]
Patch
Comment 2 Adam Barth 2012-08-22 20:03:38 PDT 
Comment on attachment 160067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160067&action=review

> Source/WebCore/bindings/v8/ScriptController.cpp:309
> +    v8::Handle<v8::Context> v8Context = ScriptController::mainWorldContext(m_proxy->frame());

m_proxy->frame() is just m_frame, right?
Comment 3 Kentaro Hara 2012-08-22 20:42:35 PDT 
Committed r126388: <http://trac.webkit.org/changeset/126388>
Comment 4 Kentaro Hara 2012-08-22 20:43:16 PDT 
(In reply to comment #2)
> > +    v8::Handle<v8::Context> v8Context = ScriptController::mainWorldContext(m_proxy->frame());
> 
> m_proxy->frame() is just m_frame, right?

Done. Thanks.