Bug 94759 - Fixing some tests in the safari-536.26-branch branch
Summary: Fixing some tests in the safari-536.26-branch branch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-22 17:20 PDT by Mark Lam
Modified: 2012-08-22 19:33 PDT (History)
1 user (show)

See Also:


Attachments
Fix. (11.63 KB, patch)
2012-08-22 17:24 PDT, Mark Lam
slewis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2012-08-22 17:20:26 PDT
Fixing some tests in the safari-536.26-branch branch.  These tests were erroneously referencing window.testRunner instead of window.layoutTestController.  Also update the expected file of 2 tests.
Comment 1 Mark Lam 2012-08-22 17:24:02 PDT
Created attachment 160042 [details]
Fix.
Comment 2 WebKit Review Bot 2012-08-22 18:15:14 PDT
Comment on attachment 160042 [details]
Fix.

Rejecting attachment 160042 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
tching file LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt.rej
patching file LayoutTests/plugins/npruntime/overrides-all-properties.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Stephanie ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13564494
Comment 3 Mark Rowe (bdash) 2012-08-22 19:33:39 PDT
I landed this in r126384.