Bug 94757 - IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
Summary: IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-22 16:38 PDT by Joshua Bell
Modified: 2012-08-23 11:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.57 KB, patch)
2012-08-22 16:39 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (10.27 KB, patch)
2012-08-22 17:24 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-08-22 16:38:05 PDT 
IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
Comment 1 Joshua Bell 2012-08-22 16:39:22 PDT 
Created attachment 160033 [details]
Patch
Comment 2 Joshua Bell 2012-08-22 16:43:31 PDT 
We discussed doing this in one of the upgradeneeded bugs but I can't find it at the moment. I think we thought it was a good idea - helps split up IDBRequest a bit, at any rate.

dgrogan@, please take a look.
Comment 3 David Grogan 2012-08-22 16:49:15 PDT 
Comment on attachment 160033 [details]
Patch

LGTM

Yes, I remember talking about this.
Comment 4 WebKit Review Bot 2012-08-22 16:58:45 PDT 
Comment on attachment 160033 [details]
Patch

Attachment 160033 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13571413
Comment 5 Joshua Bell 2012-08-22 17:24:20 PDT 
Created attachment 160043 [details]
Patch
Comment 6 Joshua Bell 2012-08-23 10:17:18 PDT 
Failure was a test case exercising a now-removed method from IDBRequest. Patch updated.

tony@ - r?
Comment 7 WebKit Review Bot 2012-08-23 11:56:07 PDT 
Comment on attachment 160043 [details]
Patch

Clearing flags on attachment: 160043

Committed r126461: <http://trac.webkit.org/changeset/126461>
Comment 8 WebKit Review Bot 2012-08-23 11:56:10 PDT 
All reviewed patches have been landed.  Closing bug.