Right now, vertex attribute sizes are literal constants in CustomFilterMesh.cpp like this:
static const unsigned AttachedMeshVertexSize = 4 + // vec4 a_position
2 + // vec2 a_texCoord
2; // vec2 a_meshCoord
It would be better to make them public members of CustomFilterMesh like this:
static const unsigned PositionAttribSize = 4;
static const unsigned TexAttribSize = 2;
That way, we can use the constants when we bind the attributes in FECustomFilter::bindProgramAndBuffers.
Created attachment 167797 [details]
Comment on attachment 167797 [details]
Clearing flags on attachment: 167797
Committed r130797: <http://trac.webkit.org/changeset/130797>
All reviewed patches have been landed. Closing bug.
Thanks for the review, Dean!
The path for CustomFilterConstants.h in the build system doesn't match the path where you placed the file. Which is right?
I'm going to move the file to the filters directory. Please fix if that's not the right thing to do.
(In reply to comment #6)
> I'm going to move the file to the filters directory. Please fix if that's not the right thing to do.
You're right. Thanks Adam!