Bug 94754 - RenderMarquee should be a RenderBlock
: RenderMarquee should be a RenderBlock
Status: NEW
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 528+ (Nightly build)
: All All
: P3 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-22 15:46 PDT by Julien Chaffraix
Modified: 2013-01-25 18:30 PST (History)
5 users (show)

See Also:


Attachments
Prototype patch: not for review as it doesn't have proper test coverage (45.56 KB, patch)
2012-08-22 15:47 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff
Updated concept patch: manually tested to work (36.82 KB, patch)
2013-01-25 18:30 PST, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-08-22 15:46:28 PDT
Currently RenderMarquee is not a RenderObject and hangs off RenderLayer. It should be the other way around ie it's a RenderObject with a RenderLayer (or maybe even without one).

The most delicate part of this change is that we have very little coverage for RenderMarquee and the existing testing is very timing dependant (same issue as animation). We would need to increase the coverage before landing such a refactoring.
Comment 1 Julien Chaffraix 2012-08-22 15:47:56 PDT
Created attachment 160025 [details]
Prototype patch: not for review as it doesn't have proper test coverage
Comment 2 Julien Chaffraix 2013-01-25 18:30:27 PST
Created attachment 184850 [details]
Updated concept patch: manually tested to work