WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
94754
RenderMarquee should be a RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=94754
Summary
RenderMarquee should be a RenderBlock
Julien Chaffraix
Reported
2012-08-22 15:46:28 PDT
Currently RenderMarquee is not a RenderObject and hangs off RenderLayer. It should be the other way around ie it's a RenderObject with a RenderLayer (or maybe even without one). The most delicate part of this change is that we have very little coverage for RenderMarquee and the existing testing is very timing dependant (same issue as animation). We would need to increase the coverage before landing such a refactoring.
Attachments
Prototype patch: not for review as it doesn't have proper test coverage
(45.56 KB, patch)
2012-08-22 15:47 PDT
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
Updated concept patch: manually tested to work
(36.82 KB, patch)
2013-01-25 18:30 PST
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2012-08-22 15:47:56 PDT
Created
attachment 160025
[details]
Prototype patch: not for review as it doesn't have proper test coverage
Julien Chaffraix
Comment 2
2013-01-25 18:30:27 PST
Created
attachment 184850
[details]
Updated concept patch: manually tested to work
Ahmad Saleem
Comment 3
2022-09-12 04:29:56 PDT
Simon & Alan - Is this needed anymore? or it is "RESOLVED LATER"? Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug