Bug 94747 - Test cases under fast/filesystem/workers are flaky when using JSC
Summary: Test cases under fast/filesystem/workers are flaky when using JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-22 13:56 PDT by Leo Yang
Modified: 2012-08-23 09:58 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.61 KB, patch)
2012-08-22 14:14 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
Patch v2 (13.37 KB, patch)
2012-08-22 14:23 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-08-22 13:56:57 PDT 
These test cases sometimes can't complete because the worker object created by startWorker() has been gc'ed before the worker thread complete. We should reference the worker object returned by startWorker() to avoid being gc'ed.

Patch is coming.
Comment 1 Leo Yang 2012-08-22 14:14:07 PDT 
Created attachment 160009 [details]
Patch
Comment 2 Leo Yang 2012-08-22 14:17:24 PDT 
Comment on attachment 160009 [details]
Patch

Hold on. There are more cases need to be updated.
Comment 3 Leo Yang 2012-08-22 14:23:02 PDT 
Created attachment 160011 [details]
Patch v2
Comment 4 Yong Li 2012-08-22 14:28:02 PDT 
Comment on attachment 160011 [details]
Patch v2

LGTM
Comment 5 WebKit Review Bot 2012-08-22 15:22:50 PDT 
Comment on attachment 160011 [details]
Patch v2

Clearing flags on attachment: 160011

Committed r126358: <http://trac.webkit.org/changeset/126358>
Comment 6 WebKit Review Bot 2012-08-22 15:22:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2012-08-23 09:58:51 PDT 
>        These test cases sometimes can't complete because the worker object
>        created by startWorker() has been gc'ed before the worker thread complete.

Is this correct behavior, or a bug in JSC bindings?