Bug 94744 - [EFL][GTK] Use WTF_USE_SOUP instead BUILDING_SOUP__
Summary: [EFL][GTK] Use WTF_USE_SOUP instead BUILDING_SOUP__
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-22 13:22 PDT by Jesus Sanchez-Palencia
Modified: 2012-08-23 11:29 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2012-08-22 13:29 PDT, Jesus Sanchez-Palencia 		no flags Details | Formatted Diff | Diff
Patch (2.59 KB, patch)
2012-08-23 08:27 PDT, Jesus Sanchez-Palencia 		gustavo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2012-08-22 13:22:23 PDT 
There is still one usage of #if defined(BUILDING_SOUP__) in WebKit2/Shared/API/c/WKBase.h and currently this only defined by the efl port in cmake/OptionsEfl.cmake . I believe #if USE(SOUP) could be used instead.
Comment 1 Jesus Sanchez-Palencia 2012-08-22 13:29:21 PDT 
Created attachment 160001 [details]
Patch
Comment 2 Build Bot 2012-08-22 14:02:25 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13573004
Comment 3 Early Warning System Bot 2012-08-22 14:08:19 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13559432
Comment 4 Martin Robinson 2012-08-22 14:15:39 PDT 
Is WebKit2/Shared/API/c/WKBase.h is a public header? If so we probably shouldn't use WTF macros there.
Comment 5 Gyuyoung Kim 2012-08-22 14:19:13 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13569376
Comment 6 Build Bot 2012-08-22 14:59:20 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13567394
Comment 7 Gustavo Noronha (kov) 2012-08-22 16:46:59 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13565473
Comment 8 Jesus Sanchez-Palencia 2012-08-23 07:57:05 PDT 
(In reply to comment #4)
> Is WebKit2/Shared/API/c/WKBase.h is a public header? If so we probably shouldn't use WTF macros there.

Yep, you are right, we can't use the macros but we can use #if defined(WTF_USE_SOUP) I guess. I've tested it locally and it worked with efl, I'm trying Qt and Gtk now.
Comment 9 Jesus Sanchez-Palencia 2012-08-23 08:27:52 PDT 
Created attachment 160169 [details]
Patch
Comment 10 Gustavo Noronha (kov) 2012-08-23 11:06:21 PDT 
Comment on attachment 160169 [details]
Patch

This looks no worse than what we already have, go ahead =)
Comment 11 Jesus Sanchez-Palencia 2012-08-23 11:28:28 PDT 
Committed r126453: <http://trac.webkit.org/changeset/126453>