Bug 94736 – [CSS Shaders] [ANGLE] RenameFunction::RenameFunction may store references to temporary string

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Joshua Netterfield]

http://code.google.com/p/angleproject/issues/detail?id=360

When RenameFunction::RenameFunction(const TString& oldFunctionName, const TString& newFunctionName) is called from TCompiler::rewriteCSSShader(TIntermNode*), references to the temporaries oldFunctionName and newFunctionName are stored as mOldFunctionName and mNewFunctionName. This results in undefined behaviour in visitAggregate.

Possible fix in RenameFunction.h:
 private:
-    const TString& mOldFunctionName;
+    const TString mOldFunctionName;
-    const TString& mNewFunctionName;
+    const TString mNewFunctionName;

[Max Vujovic]

Good catch. Thanks Joshua. We'll fix this in ANGLE first.

[Joshua Netterfield]

Created attachment 160263 [details]
Patch

[Max Vujovic]

Thanks for the patch! FYI, you don't need to worry about the style bot when you're touching ANGLE code. We have bug 90909 to teach the style bot to ignore the ANGLE directory.

[George Staikos]

(In reply to comment #1)
> Good catch. Thanks Joshua. We'll fix this in ANGLE first.

Are you saying you would rather the patch not land here but instead in ANGLE first?

[Joshua Netterfield]

The whole ANGLE directory gets replaced with the latest version from Google every once in a while. IMO, there's no point in updating all of ANGLE just for this.

[Max Vujovic]

(In reply to comment #4)
> (In reply to comment #1)
> > Good catch. Thanks Joshua. We'll fix this in ANGLE first.
> 
> Are you saying you would rather the patch not land here but instead in ANGLE first?

That's what I was saying, but I think it's fine to land this now, since we have a patch prepped for ANGLE already.

(In reply to comment #5)
> The whole ANGLE directory gets replaced with the latest version from Google every once in a while. IMO, there's no point in updating all of ANGLE just for this.

I totally agree.

[WebKit Review Bot]

Comment on attachment 160263 [details]
Patch

Clearing flags on attachment: 160263

Committed r126625: <http://trac.webkit.org/changeset/126625>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Max Vujovic]

Fix has been upstreamed in ANGLE r1266: 
http://code.google.com/p/angleproject/source/detail?r=1266