Bug 94724 – [BlackBerry] Extend LayerFilterRenderer in preparation for CSS Shaders

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Joshua Netterfield]

There are some features missing in LayerFilterRenderer that are needed to implement CSS Shaders for BB10.

[Joshua Netterfield]

Created attachment 160262 [details]
Patch

[Arvid Nilsson]

Comment on attachment 160262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160262&action=review

LGTM, but please remove copy/paste in favor of LayerRenderer::orthoMatrix()

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:240
> +static void orthogonalProjectionMatrix(TransformationMatrix& matrix, float left, float right, float bottom, float top)

This code is already available in LayerRenderer::orthoMatrix(), no need for copy/paste

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.h:48
> +    virtual void onCompletion() { }

The "on" prefix is not typically used in WebKit, instead they use the will/did/should or other prefixes. In this case, maybe a better name that doesn't even need a prefix can be made. The name is nothing to R- for, but it is unusual for the WebKit codebase.

Since the calling function is called cleanUp() maybe this could be called cleanUp() to, but I'm not sure. To me, it looks like the clean up performed is mostly related to restoring state, so maybe restoreState() or something along those lines would make sense.

[Joshua Netterfield]

Created attachment 160419 [details]
Patch

[Arvid Nilsson]

Comment on attachment 160419 [details]
Patch

Looks great!

[WebKit Review Bot]

Comment on attachment 160419 [details]
Patch

Clearing flags on attachment: 160419

Committed r126587: <http://trac.webkit.org/changeset/126587>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.