Bug 94722 - [BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain
Summary: [BlackBerry] Add a check to filter out cookies that tries to set the domain t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-22 10:00 PDT by otcheung
Modified: 2012-08-23 16:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2012-08-22 10:10 PDT, otcheung 		no flags Details | Formatted Diff | Diff
Patch (2.39 KB, patch)
2012-08-22 10:30 PDT, otcheung 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-01 (570.59 KB, application/zip)
2012-08-22 11:25 PDT, WebKit Review Bot 		no flags Details
Patch (2.15 KB, patch)
2012-08-23 15:04 PDT, otcheung 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2012-08-22 10:00:05 PDT 
Adding country-code & normal TLD checks to prevent cookies from setting cookies to top level domains.
Comment 1 otcheung 2012-08-22 10:10:21 PDT 
Created attachment 159958 [details]
Patch
Comment 2 Rob Buis 2012-08-22 10:23:47 PDT 
Comment on attachment 159958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159958&action=review

Looks good, needs some cleanup still.

> Source/WebCore/ChangeLog:2
> +

Remove one empty line here.

> Source/WebCore/ChangeLog:11
> +        If it is, throw it out when parsing

Lacks a period at the end.

> Source/WebCore/ChangeLog:18
> +        and launcher commit.

This seems not relevant here. I think it is better when adding the unit test to refer to this bug.
Comment 3 otcheung 2012-08-22 10:30:42 PDT 
Created attachment 159959 [details]
Patch
Comment 4 Rob Buis 2012-08-22 10:34:22 PDT 
Comment on attachment 159959 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2012-08-22 11:25:42 PDT 
Comment on attachment 159959 [details]
Patch

Rejecting attachment 159959 [details] from commit-queue.

New failing tests:
http/tests/cache/post-with-cached-subresources.php
Full output: http://queues.webkit.org/results/13558384
Comment 6 WebKit Review Bot 2012-08-22 11:25:44 PDT 
Created attachment 159977 [details]
Archive of layout-test-results from gce-cq-01

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 WebKit Review Bot 2012-08-22 12:36:31 PDT 
Comment on attachment 159959 [details]
Patch

Clearing flags on attachment: 159959

Committed r126336: <http://trac.webkit.org/changeset/126336>
Comment 8 WebKit Review Bot 2012-08-22 12:36:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 otcheung 2012-08-23 15:04:18 PDT 
Reopening to attach new patch.
Comment 10 otcheung 2012-08-23 15:04:26 PDT 
Created attachment 160258 [details]
Patch
Comment 11 Rob Buis 2012-08-23 15:26:40 PDT 
Comment on attachment 160258 [details]
Patch

Looks good.
Comment 12 WebKit Review Bot 2012-08-23 16:48:27 PDT 
Comment on attachment 160258 [details]
Patch

Clearing flags on attachment: 160258

Committed r126504: <http://trac.webkit.org/changeset/126504>
Comment 13 WebKit Review Bot 2012-08-23 16:48:30 PDT 
All reviewed patches have been landed.  Closing bug.