Bug 94720 - r126257 broke css3/flexbox/flexitem.html
Summary: r126257 broke css3/flexbox/flexitem.html
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
: 94675 (view as bug list)
Depends on:
Reported: 2012-08-22 09:33 PDT by Mark Lam
Modified: 2012-08-30 13:27 PDT (History)
9 users (show)

See Also:

Patch (7.38 KB, patch)
2012-08-29 12:37 PDT, Tony Chang
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2012-08-22 09:33:58 PDT
Change in rev 126257 (https://bugs.webkit.org/show_bug.cgi?id=94237) caused a regress in css3/flexbox/flexitem.html on platform mac.  See http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r126303%20(2117)/css3/flexbox/flexitem-pretty-diff.html.
Comment 1 Shezan Baig 2012-08-22 09:46:37 PDT
Hmm, I can understand the reasons for different widths in the last test case, and I believe this will be fixed by bug 94604, but it's odd that the widths of the blue-100 and green-10 images would be affected by this change.  I'll look to see if there's any mac specific code in the image layout, but I don't have a mac so my debugging will be limited to code inspection.  Ojan, do you have any idea why the widths of these image would be affected by this change?
Comment 2 Ojan Vafai 2012-08-22 11:58:33 PDT
*** Bug 94675 has been marked as a duplicate of this bug. ***
Comment 3 Ojan Vafai 2012-08-22 12:01:57 PDT
I don't think this is platform-specific. Instead, I think you're additions to the test exposed a race condition on the images actually loading. Notice that the height of the image that's supposed to stretch is also wrong. It's clearly not the C++ change that caused the failure.

Also, it consistently passes on Chromium Linux release and is flaky on Chromium Linux debug:

I'm not really sure where the race is though. We don't check the dimensions of the flex items until the body's onload event, which AFAIK should happen after all the images/iframes have loaded.
Comment 4 Mark Lam 2012-08-22 12:39:32 PDT
css3/flexbox/flexitem.html has been skipped in r126337 (https://bugs.webkit.org/show_bug.cgi?id=94723).  Please revert r126337 when this issue is resolved.  Thanks.
Comment 5 Ojan Vafai 2012-08-22 14:35:45 PDT
I can't get this to fail locally for me with a Chromium Linux debug build. :(
Comment 6 Ojan Vafai 2012-08-24 16:57:43 PDT
This test now passed for GTK and Chromium release. It fails or is flaky on all the Chromium debug bots. Seem like we should try unskipping it for other ports.
Comment 7 Ojan Vafai 2012-08-24 18:13:26 PDT
Specifically, we should unskip for mac and mark the Chromium failure as debug only.

Qt and EFL were already skipping this test for other reasons, so I think we should leave those alone.
Comment 8 Tony Chang 2012-08-29 12:37:00 PDT
Created attachment 161285 [details]
Comment 9 Tony Chang 2012-08-29 14:23:20 PDT
Committed r127050: <http://trac.webkit.org/changeset/127050>