Bug 94715 – [V8] Remove V8Proxy from getXPathNSResolver()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

- The V8Proxy* argument of getXPathNSResolver(..., V8Proxy* = 0) is not used. We can remove it.
- We can rename getXPathNSResolver() to toXPathNSResolver().
- We can move toXPathNSResolver() from V8DOMWrapper to V8Binding, since other toXXX() methods are written in V8Binding.

[Kentaro Hara]

Created attachment 159947 [details]
Patch

[Adam Barth]

Comment on attachment 159947 [details]
Patch

It seems odd that XPathNSResolver needs this special-case code.  How do we do this in the general case?

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 159947 [details])
> It seems odd that XPathNSResolver needs this special-case code.  How do we do this in the general case?

Generated code by default:

  if (V8XPathNSResolver::HasInstance(value))
    return V8XPathNSResolver::toNative(value)
  return 0;

What XPathNSResolver expects:

  if (V8XPathNSResolver::HasInstance(value))
    return V8XPathNSResolver::toNative(value);
  else if (value->IsObject())
    return V8CustomXPathNSResolver::create(value->ToObject());
  return 0;

It looks like that XPathNSResolver wants to fall back to V8CustomXPathNSResolver. (I don't know why though.)

[WebKit Review Bot]

Comment on attachment 159947 [details]
Patch

Clearing flags on attachment: 159947

Committed r126375: <http://trac.webkit.org/changeset/126375>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.