Bug 94713 – [V8] Remove V8Proxy from V8DOMWrapper::instantiateV8Object()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

V8DOMWrapper::instantiateV8Object() should receive Frame* instead of V8Proxy*.

[Kentaro Hara]

Created attachment 159939 [details]
Patch

[Kentaro Hara]

Comment on attachment 159939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159939&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3408
> +    wrapper = V8DOMWrapper::instantiateV8Object(proxy ? proxy->frame() : 0, &info, impl.get());

'proxy' will be removed from CodeGeneratorV8.pm in a follow-up patch (because removing 'proxy' is not so trivial).

[Adam Barth]

Comment on attachment 159939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159939&action=review

> Source/WebCore/bindings/v8/V8DOMWrapper.cpp:163
> -v8::Local<v8::Object> V8DOMWrapper::instantiateV8Object(V8Proxy* proxy, WrapperTypeInfo* type, void* impl)
> +v8::Local<v8::Object> V8DOMWrapper::instantiateV8Object(Frame* frame, WrapperTypeInfo* type, void* impl)

This should actually take a ScriptExecutionContext, but Frame is better than V8Proxy :)

> Source/WebCore/bindings/v8/V8DOMWrapper.cpp:175
> -                Frame* frame = V8DOMWindow::toNative(globalPrototype)->frame();
> -                if (frame && frame->script()->canExecuteScripts(NotAboutToExecuteScript))
> -                    proxy = frame->script()->proxy();
> +                Frame* globalFrame = V8DOMWindow::toNative(globalPrototype)->frame();
> +                if (globalFrame && globalFrame->script()->canExecuteScripts(NotAboutToExecuteScript))
> +                    frame = globalFrame;

This code is wrong, but we can fix that in another patch.  Can you file a bug about V8DOMWrapper::instantiateV8Object needing to take a ScriptExecutionContext ?

[WebKit Review Bot]

Comment on attachment 159939 [details]
Patch

Clearing flags on attachment: 159939

Committed r126362: <http://trac.webkit.org/changeset/126362>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kentaro Hara]

(In reply to comment #3)
> This code is wrong, but we can fix that in another patch.  Can you file a bug about V8DOMWrapper::instantiateV8Object needing to take a ScriptExecutionContext ?

Filed a bug 94763.