The WebBackForwardList getters should be const for the following reasons: 1) WebBackForwardList getters are not consistent with each other (WebBackForwardList::entries() is const but WebBackForwardList::currentIndex() is not). 2) Every programmer expects a getter to be const.
Created attachment 159934 [details] patch
Comment on attachment 159934 [details] patch Wrong diff :(
Created attachment 159941 [details] patch
Comment on attachment 159941 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=159941&action=review > Source/WebKit2/ChangeLog:10 > + Besides having a not const getters looks like bad C++ style. double spacing. bad C++ style, explain?
Created attachment 159962 [details] patch v2 Added explanation to ChangeLog.
Comment on attachment 159962 [details] patch v2 Rejecting attachment 159962 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing Tools/ChangeLog CONFLICT (content): Merge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 Unreviewed, add aelias@chromium.org to committers When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13567353
Created attachment 160113 [details] to be landed
Comment on attachment 160113 [details] to be landed Clearing flags on attachment: 160113 Committed r126406: <http://trac.webkit.org/changeset/126406>
All reviewed patches have been landed. Closing bug.