Bug 94692 - [Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation
Summary: [Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
Keywords: Qt, QtTriaged
Depends on:
Reported: 2012-08-22 04:50 PDT by Csaba Osztrogonác
Modified: 2012-08-22 06:21 PDT (History)
7 users (show)

See Also:

Patch (1.48 KB, patch)
2012-08-22 05:27 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-08-22 04:50:02 PDT
After https://trac.webkit.org/changeset/126057/trunk/Source/WebCore/page/DOMWindow.cpp
the following tests started to fail: (because DeviceMotion and DeviceOrientation runtime
enabled features are disabled on Qt WK2 and it wasn't checked before.)
- fast/dom/DeviceMotion/no-page-cache.html
- fast/dom/DeviceOrientation/no-page-cache.html

I tried to enable them and then these tests pass. Now there are 4-4 non-skipped 
DeviceMotion and DeviceOrientation tests on Qt-WK2 and all of them pass.
Comment 1 Csaba Osztrogonác 2012-08-22 05:27:03 PDT
Created attachment 159909 [details]
Comment 2 Csaba Osztrogonác 2012-08-22 05:27:36 PDT
They were disabled by https://trac.webkit.org/changeset/73876 
(two years before) because of crashes. But now they work fine.
Comment 3 Simon Hausmann 2012-08-22 06:06:21 PDT
Awesome, thanks Ossy! :)
Comment 4 WebKit Review Bot 2012-08-22 06:21:36 PDT
Comment on attachment 159909 [details]

Clearing flags on attachment: 159909

Committed r126296: <http://trac.webkit.org/changeset/126296>
Comment 5 WebKit Review Bot 2012-08-22 06:21:39 PDT
All reviewed patches have been landed.  Closing bug.