Bug 94684 - Get rid of m_useLatchedWheelEventNode
Summary: Get rid of m_useLatchedWheelEventNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks: 94478
  Show dependency treegraph
 
Reported: 2012-08-22 02:43 PDT by Allan Sandfeld Jensen
Modified: 2012-08-24 01:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.33 KB, patch)
2012-08-22 03:13 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-08-22 02:43:28 PDT
EventHandler has a "global" flag called m_useLatchedWheelEventNode which is used only to tell if the currently handled wheel-event should use latched nodes. Since this is event specific, this flag would be better to have in PlatformWheelEvent.
Comment 1 Allan Sandfeld Jensen 2012-08-22 03:13:36 PDT
Created attachment 159892 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-22 13:27:26 PDT
Comment on attachment 159892 [details]
Patch

LGTM.  Did you CC whoever added this originally?  Do we have ways to test this?
Comment 3 Robert Kroeger 2012-08-22 13:38:46 PDT
fwiw: I like this change.

regarding tests: it would be really if EventSender permitted setting the latched flag yes? That would make it possible to expand the existing layout tests in fast/event/touch/gesture to be enhanced to show that latched/non-latched mode are getting handled correctly.
Comment 4 Allan Sandfeld Jensen 2012-08-22 13:43:12 PDT
(In reply to comment #2)
> (From update of attachment 159892 [details])
> LGTM.  Did you CC whoever added this originally?  Do we have ways to test this?

Anders Carlson seems to have added it to EventHandler.cpp, and Timothy last touched it, I CC'ed both of them.

There is no real change in functionality to test. It does appears to be tested indirectly by a number of tests, at least I had some tests breaking when I had a bug in an earlier version of the patch
Comment 5 Ryosuke Niwa 2012-08-23 23:31:31 PDT
Comment on attachment 159892 [details]
Patch

This looks right.
Comment 6 WebKit Review Bot 2012-08-24 01:40:32 PDT
Comment on attachment 159892 [details]
Patch

Clearing flags on attachment: 159892

Committed r126556: <http://trac.webkit.org/changeset/126556>
Comment 7 WebKit Review Bot 2012-08-24 01:40:35 PDT
All reviewed patches have been landed.  Closing bug.