API to get/set spellchecking languages, uses a string containing a list of languages separated by commas. We are splitting the list into a vector to update the enchant dictionaries, and building a comma separated string from enchant dictionaries to return the list of languages. On the other hand, set_preferred_languages receives a GList of string with the language identifiers. It would be more convenient to use a GStrv in both cases (we avoid unnecessary split/join in spellchecker case), and would result in a more consistent API.
Created attachment 159886 [details]
This is an api break so it would be great to land it before the release.
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
As the author of the previous version of this API, I must say I agree with this change and that the current patch looks good to me too
Comment on attachment 159886 [details]
Committed r126298: <http://trac.webkit.org/changeset/126298>