Bug 94662 - IndexedDB: revert int version when version change transaction aborts
Summary: IndexedDB: revert int version when version change transaction aborts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 18:20 PDT by David Grogan
Modified: 2012-08-22 16:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.50 KB, patch)
2012-08-21 18:26 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Patch (10.68 KB, patch)
2012-08-22 14:54 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-04 (1.33 MB, application/zip)
2012-08-22 15:46 PDT, WebKit Review Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-08-21 18:20:35 PDT 
IndexedDB: revert int version when version change transaction aborts
Comment 1 David Grogan 2012-08-21 18:26:43 PDT 
Created attachment 159836 [details]
Patch
Comment 2 David Grogan 2012-08-21 18:27:27 PDT 
Josh, could you look at this?
Comment 3 Joshua Bell 2012-08-22 11:36:31 PDT 
Comment on attachment 159836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159836&action=review

lgtm

> LayoutTests/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Replace this with brief overview.

> LayoutTests/storage/indexeddb/resources/intversion-revert-on-abort.js:60
> +    request.onerror = errorAfterAbortCallback;

unexpectedErrorCallback?
Comment 4 David Grogan 2012-08-22 14:52:10 PDT 
Comment on attachment 159836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159836&action=review

>> LayoutTests/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Replace this with brief overview.

Done.

>> LayoutTests/storage/indexeddb/resources/intversion-revert-on-abort.js:60
>> +    request.onerror = errorAfterAbortCallback;
> 
> unexpectedErrorCallback?

Oops, fixed.
Comment 5 David Grogan 2012-08-22 14:54:23 PDT 
Created attachment 160015 [details]
Patch
Comment 6 David Grogan 2012-08-22 14:54:48 PDT 
Tony, could you review this?
Comment 7 WebKit Review Bot 2012-08-22 15:46:26 PDT 
Comment on attachment 160015 [details]
Patch

Attachment 160015 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13569402

New failing tests:
http/tests/cache/post-with-cached-subresources.php
Comment 8 WebKit Review Bot 2012-08-22 15:46:29 PDT 
Created attachment 160024 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 9 WebKit Review Bot 2012-08-22 16:23:23 PDT 
Comment on attachment 160015 [details]
Patch

Clearing flags on attachment: 160015

Committed r126366: <http://trac.webkit.org/changeset/126366>
Comment 10 WebKit Review Bot 2012-08-22 16:23:26 PDT 
All reviewed patches have been landed.  Closing bug.