Bug 94662 – IndexedDB: revert int version when version change transaction aborts

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[David Grogan]

IndexedDB: revert int version when version change transaction aborts

[David Grogan]

Created attachment 159836 [details]
Patch

[David Grogan]

Josh, could you look at this?

[Joshua Bell]

Comment on attachment 159836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159836&action=review

lgtm

> LayoutTests/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Replace this with brief overview.

> LayoutTests/storage/indexeddb/resources/intversion-revert-on-abort.js:60
> +    request.onerror = errorAfterAbortCallback;

unexpectedErrorCallback?

[David Grogan]

Comment on attachment 159836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159836&action=review

>> LayoutTests/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Replace this with brief overview.

Done.

>> LayoutTests/storage/indexeddb/resources/intversion-revert-on-abort.js:60
>> +    request.onerror = errorAfterAbortCallback;
> 
> unexpectedErrorCallback?

Oops, fixed.

[David Grogan]

Created attachment 160015 [details]
Patch

[David Grogan]

Tony, could you review this?

[WebKit Review Bot]

Comment on attachment 160015 [details]
Patch

Attachment 160015 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13569402

New failing tests:
http/tests/cache/post-with-cached-subresources.php

[WebKit Review Bot]

Created attachment 160024 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[WebKit Review Bot]

Comment on attachment 160015 [details]
Patch

Clearing flags on attachment: 160015

Committed r126366: <http://trac.webkit.org/changeset/126366>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.