Bug 94659 - Add myself to the committer list
Summary: Add myself to the committer list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Victor Carbune
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 18:14 PDT by Victor Carbune
Modified: 2012-08-22 17:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2012-08-21 18:20 PDT, Victor Carbune 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Carbune 2012-08-21 18:14:53 PDT 
Add myself to the committer list
Comment 1 Victor Carbune 2012-08-21 18:20:41 PDT 
Created attachment 159834 [details]
Patch
Comment 2 James Robinson 2012-08-21 18:26:38 PDT 
Comment on attachment 159834 [details]
Patch

You don't technically need a review for this, but r+ anyway. By tradition you should land this by hand to make sure your SVN credentials work.
Comment 3 Victor Carbune 2012-08-21 18:50:22 PDT 
(In reply to comment #2)
> (From update of attachment 159834 [details])
> You don't technically need a review for this, but r+ anyway. By tradition you should land this by hand to make sure your SVN credentials work.
Sounds good, I'll manually land this then.
Comment 4 Victor Carbune 2012-08-22 17:16:00 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 159834 [details] [details])
> > You don't technically need a review for this, but r+ anyway. By tradition you should land this by hand to make sure your SVN credentials work.
> Sounds good, I'll manually land this then.
Done, everything seems to be working properly. Thanks.
Comment 5 Victor Carbune 2012-08-22 17:20:57 PDT 
Manually committed r126368: http://trac.webkit.org/changeset/126368