Bug 94649 - Populate DatabaseTracker's origins lazily on demand
Summary: Populate DatabaseTracker's origins lazily on demand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 16:51 PDT by Benjamin Poulain
Modified: 2012-08-24 16:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.02 KB, patch)
2012-08-21 16:59 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (5.19 KB, patch)
2012-08-24 15:18 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-08-21 16:51:51 PDT 
Synchronous accesses to the disk = BAD!
Comment 1 Benjamin Poulain 2012-08-21 16:59:09 PDT 
Created attachment 159806 [details]
Patch
Comment 2 Brady Eidson 2012-08-24 14:22:02 PDT 
Comment on attachment 159806 [details]
Patch

I would like to see populateOrigins() renamed to populateOriginsIfNeeded() to make it clear to readers of the individual functions that there's no recurring side effect or cost.
Comment 3 Benjamin Poulain 2012-08-24 15:18:01 PDT 
Created attachment 160510 [details]
Patch
Comment 4 WebKit Review Bot 2012-08-24 16:18:32 PDT 
Comment on attachment 160510 [details]
Patch

Clearing flags on attachment: 160510

Committed r126648: <http://trac.webkit.org/changeset/126648>
Comment 5 WebKit Review Bot 2012-08-24 16:18:35 PDT 
All reviewed patches have been landed.  Closing bug.