WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94637
Remove UndoManager's undoscope content attribute
https://bugs.webkit.org/show_bug.cgi?id=94637
Summary
Remove UndoManager's undoscope content attribute
Sukolsak Sakshuwong
Reported
2012-08-21 14:28:02 PDT
Remove UndoManager's undoscope content attribute as per discussion on #whatwg.
Attachments
Patch
(33.67 KB, patch)
2012-08-21 15:26 PDT
,
Sukolsak Sakshuwong
no flags
Details
Formatted Diff
Diff
Patch for landing
(34.81 KB, patch)
2012-08-21 15:46 PDT
,
Sukolsak Sakshuwong
no flags
Details
Formatted Diff
Diff
Patch for landing
(34.80 KB, patch)
2012-08-21 15:54 PDT
,
Sukolsak Sakshuwong
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1
2012-08-21 15:26:06 PDT
Created
attachment 159779
[details]
Patch
Ryosuke Niwa
Comment 2
2012-08-21 15:30:53 PDT
Comment on
attachment 159779
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=159779&action=review
> Source/WebCore/bindings/v8/DOMTransaction.cpp:96 > + Frame* frame = m_undoManager->undoScopeHost()->frame();
We should probably rename undoScopeHost() to document().
Sukolsak Sakshuwong
Comment 3
2012-08-21 15:46:32 PDT
Created
attachment 159782
[details]
Patch for landing
Ryosuke Niwa
Comment 4
2012-08-21 15:51:45 PDT
Comment on
attachment 159782
[details]
Patch for landing Let's wait until we can sort out all the details.
Sukolsak Sakshuwong
Comment 5
2012-08-21 15:54:38 PDT
Created
attachment 159784
[details]
Patch for landing
WebKit Review Bot
Comment 6
2012-08-21 18:42:21 PDT
Comment on
attachment 159784
[details]
Patch for landing Clearing flags on attachment: 159784 Committed
r126245
: <
http://trac.webkit.org/changeset/126245
>
WebKit Review Bot
Comment 7
2012-08-21 18:42:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug