Bug 94621 – [BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Benjamin Meyer]

Currently the BlackBerry port is injecting the 'qnx' JavaScript object in every WebView to provide a way for JavaScript to callback out to native through an event.  This qnx object is injected in both WebViews that are used for interacting with local resources (local webpage) and WebViews that are used for displaying public webpages (aka http://www.google.com)

As long as the current codebase has a 'qnx' object there should be a way to enable/disable the injections so it can be turned off by default on WebView's loading public webpages to prevent any possible security risk.

[Benjamin Meyer]

Created attachment 159741 [details]
patch

[Yong Li]

Comment on attachment 159741 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159741&action=review

> Source/WebKit/blackberry/Api/WebPage.h:387
> +    void enableQnxJavaScriptObject(bool);

Naming:
1. Qnx should be QNX
2. WebKit usually use setFooEnabled(boo)

[Yong Li]

Comment on attachment 159741 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159741&action=review

>> Source/WebKit/blackberry/Api/WebPage.h:387
>> +    void enableQnxJavaScriptObject(bool);
> 
> Naming:
> 1. Qnx should be QNX
> 2. WebKit usually use setFooEnabled(boo)

hm.. probably Qnx is ok because the js object is "qnx"

[Benjamin Meyer]

On the API note, the BlackBerry port api is inconsistent, has setFooEnabled(),  enableFoo() and setEnableFoo() which is why I just picked one.

[WebKit Review Bot]

Comment on attachment 159741 [details]
patch

Clearing flags on attachment: 159741

Committed r126232: <http://trac.webkit.org/changeset/126232>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.