Bug 94609 – [nrwt, WTR] Remove workaround for timeout handing from r126062

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Balazs Kelemen]

This was added in http://trac.webkit.org/changeset/126062 with a FIXME to fix properly.

[Balazs Kelemen]

Created attachment 159713 [details]
Patch

[Dirk Pranke]

Comment on attachment 159713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159713&action=review

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:178
> +                pid_str = str(self._crashed_pid) if self._crashed_pid else "uknown pid"

typo: "uknown"

> Tools/WebKitTestRunner/TestInvocation.cpp:205
> +void TestInvocation::dumpWebProcessUnresponsiveness(const char* textToStdout)

Do we need to write something to stdout at all?

[Balazs Kelemen]

(In reply to comment #2)
> (From update of attachment 159713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159713&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/driver.py:178
> > +                pid_str = str(self._crashed_pid) if self._crashed_pid else "uknown pid"
> 
> typo: "uknown"
> 
> > Tools/WebKitTestRunner/TestInvocation.cpp:205
> > +void TestInvocation::dumpWebProcessUnresponsiveness(const char* textToStdout)
> 
> Do we need to write something to stdout at all?

We did it so far, why should we change that? Knowing when has the web process became unresponsive is useful information for debugging failures.

[Balazs Kelemen]

Created attachment 159903 [details]
fixed nit

[Dirk Pranke]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 159713 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=159713&action=review
> > 
> > > Tools/Scripts/webkitpy/layout_tests/port/driver.py:178
> > > +                pid_str = str(self._crashed_pid) if self._crashed_pid else "uknown pid"
> > 
> > typo: "uknown"
> > 
> > > Tools/WebKitTestRunner/TestInvocation.cpp:205
> > > +void TestInvocation::dumpWebProcessUnresponsiveness(const char* textToStdout)
> > 
> > Do we need to write something to stdout at all?
> 
> We did it so far, why should we change that? Knowing when has the web process became unresponsive is useful information for debugging failures.

Sure, I was just thinking it's somewhat redundant with the UNRESPONSIVE error ...

[Balazs Kelemen]

Comment on attachment 159903 [details]
fixed nit

Clearing flags on attachment: 159903

Committed r126418: <http://trac.webkit.org/changeset/126418>

[Balazs Kelemen]

All reviewed patches have been landed.  Closing bug.