Bug 94609 - [nrwt, WTR] Remove workaround for timeout handing from r126062
Summary: [nrwt, WTR] Remove workaround for timeout handing from r126062
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 09:54 PDT by Balazs Kelemen
Modified: 2012-08-23 04:50 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.53 KB, patch)
2012-08-21 10:15 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
fixed nit (6.49 KB, patch)
2012-08-22 04:43 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-08-21 09:54:22 PDT
This was added in http://trac.webkit.org/changeset/126062 with a FIXME to fix properly.
Comment 1 Balazs Kelemen 2012-08-21 10:15:28 PDT
Created attachment 159713 [details]
Patch
Comment 2 Dirk Pranke 2012-08-21 11:11:11 PDT
Comment on attachment 159713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159713&action=review

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:178
> +                pid_str = str(self._crashed_pid) if self._crashed_pid else "uknown pid"

typo: "uknown"

> Tools/WebKitTestRunner/TestInvocation.cpp:205
> +void TestInvocation::dumpWebProcessUnresponsiveness(const char* textToStdout)

Do we need to write something to stdout at all?
Comment 3 Balazs Kelemen 2012-08-22 04:28:52 PDT
(In reply to comment #2)
> (From update of attachment 159713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159713&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/driver.py:178
> > +                pid_str = str(self._crashed_pid) if self._crashed_pid else "uknown pid"
> 
> typo: "uknown"
> 
> > Tools/WebKitTestRunner/TestInvocation.cpp:205
> > +void TestInvocation::dumpWebProcessUnresponsiveness(const char* textToStdout)
> 
> Do we need to write something to stdout at all?

We did it so far, why should we change that? Knowing when has the web process became unresponsive is useful information for debugging failures.
Comment 4 Balazs Kelemen 2012-08-22 04:43:39 PDT
Created attachment 159903 [details]
fixed nit
Comment 5 Dirk Pranke 2012-08-22 11:37:11 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 159713 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=159713&action=review
> > 
> > > Tools/Scripts/webkitpy/layout_tests/port/driver.py:178
> > > +                pid_str = str(self._crashed_pid) if self._crashed_pid else "uknown pid"
> > 
> > typo: "uknown"
> > 
> > > Tools/WebKitTestRunner/TestInvocation.cpp:205
> > > +void TestInvocation::dumpWebProcessUnresponsiveness(const char* textToStdout)
> > 
> > Do we need to write something to stdout at all?
> 
> We did it so far, why should we change that? Knowing when has the web process became unresponsive is useful information for debugging failures.

Sure, I was just thinking it's somewhat redundant with the UNRESPONSIVE error ...
Comment 6 Balazs Kelemen 2012-08-23 04:49:59 PDT
Comment on attachment 159903 [details]
fixed nit

Clearing flags on attachment: 159903

Committed r126418: <http://trac.webkit.org/changeset/126418>
Comment 7 Balazs Kelemen 2012-08-23 04:50:04 PDT
All reviewed patches have been landed.  Closing bug.