Bug 94602 - [Chromium/Skia] Filters should flush the SkCanvas
Summary: [Chromium/Skia] Filters should flush the SkCanvas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Salomon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 07:56 PDT by Brian Salomon
Modified: 2012-08-21 17:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2012-08-21 07:59 PDT, Brian Salomon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Salomon 2012-08-21 07:56:19 PDT 
[Chromium/Skia] Filters should flush the SkCanvas
Comment 1 Brian Salomon 2012-08-21 07:59:54 PDT 
Created attachment 159690 [details]
Patch
Comment 2 Stephen White 2012-08-21 08:02:05 PDT 
Comment on attachment 159690 [details]
Patch

Looks good, bots willing.  r=me
Comment 3 James Robinson 2012-08-21 11:19:28 PDT 
Comment on attachment 159690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159690&action=review

> Source/WebCore/ChangeLog:10
> +        Covered by existing css3/filters layout tests.

Were any of these failing before? Will they start passing now?
Comment 4 Stephen White 2012-08-21 11:41:18 PDT 
(In reply to comment #3)
> (From update of attachment 159690 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159690&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Covered by existing css3/filters layout tests.
> 
> Were any of these failing before? Will they start passing now?

They would fail (and did fail on the trybots) if we rolled past Brian's skia change we removes an implicit flush for filters.  This is a preemptive change necessary for that roll.
Comment 5 James Robinson 2012-08-21 12:24:48 PDT 
Ah, OK.  Cool!
Comment 6 WebKit Review Bot 2012-08-21 17:06:00 PDT 
Comment on attachment 159690 [details]
Patch

Clearing flags on attachment: 159690

Committed r126226: <http://trac.webkit.org/changeset/126226>
Comment 7 WebKit Review Bot 2012-08-21 17:06:03 PDT 
All reviewed patches have been landed.  Closing bug.