RESOLVED FIXED 94602
[Chromium/Skia] Filters should flush the SkCanvas 
https://bugs.webkit.org/show_bug.cgi?id=94602
Summary [Chromium/Skia] Filters should flush the SkCanvas
Brian Salomon
Reported 2012-08-21 07:56:19 PDT
[Chromium/Skia] Filters should flush the SkCanvas
Attachments
Patch (1.25 KB, patch)
2012-08-21 07:59 PDT, Brian Salomon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Salomon
Comment 1 2012-08-21 07:59:54 PDT
Created attachment 159690 [details] Patch
Stephen White
Comment 2 2012-08-21 08:02:05 PDT
Comment on attachment 159690 [details] Patch Looks good, bots willing. r=me
James Robinson
Comment 3 2012-08-21 11:19:28 PDT
Comment on attachment 159690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159690&action=review > Source/WebCore/ChangeLog:10 > + Covered by existing css3/filters layout tests. Were any of these failing before? Will they start passing now?
Stephen White
Comment 4 2012-08-21 11:41:18 PDT
(In reply to comment #3) > (From update of attachment 159690 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159690&action=review > > > Source/WebCore/ChangeLog:10 > > + Covered by existing css3/filters layout tests. > > Were any of these failing before? Will they start passing now? They would fail (and did fail on the trybots) if we rolled past Brian's skia change we removes an implicit flush for filters. This is a preemptive change necessary for that roll.
James Robinson
Comment 5 2012-08-21 12:24:48 PDT
Ah, OK. Cool!
WebKit Review Bot
Comment 6 2012-08-21 17:06:00 PDT
Comment on attachment 159690 [details] Patch Clearing flags on attachment: 159690 Committed r126226: <http://trac.webkit.org/changeset/126226>
WebKit Review Bot
Comment 7 2012-08-21 17:06:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.