Bug 94585 - range-hit-test-with-padding.html fails unless subpixel layout is on
Summary: range-hit-test-with-padding.html fails unless subpixel layout is on
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 94595
  Show dependency treegraph
 
Reported: 2012-08-21 04:09 PDT by Keishi Hattori
Modified: 2012-08-21 19:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.61 KB, patch)
2012-08-21 05:36 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2012-08-21 06:01 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-03 (505.20 KB, application/zip)
2012-08-21 10:34 PDT, WebKit Review Bot
no flags Details
Patch (2.59 KB, patch)
2012-08-21 17:55 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-08-21 04:09:45 PDT
Slider thumb width is an odd number and we divide that by two, so we get different results depending on whether subpixel layout is turned on or not.
Comment 1 Keishi Hattori 2012-08-21 05:36:44 PDT
Created attachment 159666 [details]
Patch
Comment 2 Kent Tamura 2012-08-21 05:48:26 PDT
Comment on attachment 159666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review

> LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9
> -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;">
> +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;">

I recommend adding some step value.
Comment 3 Kent Tamura 2012-08-21 05:53:38 PDT
(In reply to comment #2)
> (From update of attachment 159666 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review
> 
> > LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9
> > -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;">
> > +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;">
> 
> I recommend adding some step value.

I mean increasing the step value. e.g. step=20
Comment 4 Keishi Hattori 2012-08-21 06:01:29 PDT
Created attachment 159672 [details]
Patch
Comment 5 Keishi Hattori 2012-08-21 06:04:05 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 159666 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review
> > 
> > > LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9
> > > -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;">
> > > +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;">
> > 
> > I recommend adding some step value.
> 
> I mean increasing the step value. e.g. step=20

That is much better! Adjusted the max to 25 so this will work as long as the thumb width is less than 50px.
Comment 6 Thiago Marcos P. Santos 2012-08-21 06:20:47 PDT
This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working.

Try changing to something like "padding: 0 400px;" and test on chromium.
Comment 7 Thiago Marcos P. Santos 2012-08-21 06:21:59 PDT
(In reply to comment #6)
> This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working.
> 
> Try changing to something like "padding: 0 400px;" and test on chromium.

Sorry for bumping. By test here I'm talking about see how it looks like on the browser.
Comment 8 Thiago Marcos P. Santos 2012-08-21 06:29:15 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working.
> > 
> > Try changing to something like "padding: 0 400px;" and test on chromium.
> 
> Sorry for bumping. By test here I'm talking about see how it looks like on the browser.

Argh, EFL padding is broken. Sorry for the noise.
Comment 9 WebKit Review Bot 2012-08-21 10:34:52 PDT
Comment on attachment 159672 [details]
Patch

Attachment 159672 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13551362

New failing tests:
fast/forms/range/range-hit-test-with-padding.html
Comment 10 WebKit Review Bot 2012-08-21 10:34:55 PDT
Created attachment 159719 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 11 Keishi Hattori 2012-08-21 17:55:13 PDT
Created attachment 159825 [details]
Patch
Comment 12 WebKit Review Bot 2012-08-21 19:17:10 PDT
Comment on attachment 159825 [details]
Patch

Clearing flags on attachment: 159825

Committed r126252: <http://trac.webkit.org/changeset/126252>
Comment 13 WebKit Review Bot 2012-08-21 19:17:15 PDT
All reviewed patches have been landed.  Closing bug.