Bug 94580 – Web Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

EOM

[Ilya Tikhonovsky]

Created attachment 159639 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 159639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159639&action=review

> Source/WebCore/dom/MemoryInstrumentation.h:106
> +    void addInstrumentedObject(const String&, ObjectType);

We should merge these methods into corresponding addInstrumentedObjectImpl.

> Source/WebCore/dom/MemoryInstrumentation.h:219
> +    void addInstrumentedMember(const String& string) { m_memoryInstrumentation->addInstrumentedObject(string, m_objectType); }

Having overloaded version of addInstrumentedObjectImpl should be enough for generic addInstrumentedMember method to work here.

[Ilya Tikhonovsky]

Created attachment 159665 [details]
Patch

[Build Bot]

Comment on attachment 159665 [details]
Patch

Attachment 159665 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13554149

[Yury Semikhatsky]

Comment on attachment 159665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159665&action=review

> Source/WebCore/dom/MemoryInstrumentation.cpp:64
> +        addObject(url->innerURL(), objectType);

addObject -> addInstrumentedObject, can you check why didn't the compilation failed on this call?

[Ilya Tikhonovsky]

Created attachment 159674 [details]
Patch

[Ilya Tikhonovsky]

(In reply to comment #5)
> (From update of attachment 159665 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159665&action=review
> 
> > Source/WebCore/dom/MemoryInstrumentation.cpp:64
> > +        addObject(url->innerURL(), objectType);
> 
> addObject -> addInstrumentedObject, can you check why didn't the compilation failed on this call?

fixed.

link time guards were moved to MemoryInstrumentation

[Ilya Tikhonovsky]

Created attachment 159680 [details]
actually landed

actually landed patch