RESOLVED FIXED Bug 94567
_compare_image() swaps actual and expected images by mistake 
https://bugs.webkit.org/show_bug.cgi?id=94567
Summary _compare_image() swaps actual and expected images by mistake
Simon Fraser (smfr)
Reported 2012-08-20 20:25:57 PDT
I'm pretty sure that _compare_image() is swapping the images by mistake: diff_result = self._port.diff_image(driver_output.image, expected_driver_output.image) def diff_image(self, expected_contents, actual_contents, tolerance): Note flipped order of params.
Attachments
Patch (1.88 KB, patch)
2012-08-20 20:30 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (10.47 KB, patch)
2012-08-21 13:20 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-08-20 20:30:30 PDT
Created attachment 159604 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-08-20 21:49:38 PDT
Comment on attachment 159604 [details] Patch Dirk wants to fix this another way.
Dirk Pranke
Comment 4 2012-08-21 13:20:27 PDT
Created attachment 159751 [details] Patch
Dirk Pranke
Comment 5 2012-08-21 14:35:49 PDT
Committed r126188: <http://trac.webkit.org/changeset/126188>
Note You need to log in before you can comment on or make changes to this bug.