RESOLVED FIXED 94557
Move free functions in test_expectations to TestExpectations class 
https://bugs.webkit.org/show_bug.cgi?id=94557
Summary Move free functions in test_expectations to TestExpectations class
Ryosuke Niwa
Reported 2012-08-20 18:10:00 PDT
Move free functions in test_expectations to TestExpectations class
Attachments
Patch (15.46 KB, patch)
2012-08-20 18:11 PDT, Ryosuke Niwa 		dpranke: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-08-20 18:11:07 PDT
Created attachment 159580 [details] Patch
Dirk Pranke
Comment 2 2012-08-20 22:10:21 PDT
Comment on attachment 159580 [details] Patch I personally have nothing against free functions and think staticmethods tend to be a bad idea, but that is not the way adam and eric seemed to like things, so this is fine, too. (I think the argument is that if the function is a static method, then you can more easily override it for testing/mocking purposes without introducing side effects).
WebKit Review Bot
Comment 3 2012-08-20 22:57:56 PDT
Comment on attachment 159580 [details] Patch Rejecting attachment 159580 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: .. Auto-merging Tools/ChangeLog CONFLICT (content): Merge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 Reduce GradientAttributes object size When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13549243
Ryosuke Niwa
Comment 4 2012-08-21 11:09:49 PDT
Committed r126176: <http://trac.webkit.org/changeset/126176>
Note You need to log in before you can comment on or make changes to this bug.