Bug 94557 - Move free functions in test_expectations to TestExpectations class
Summary: Move free functions in test_expectations to TestExpectations class
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Blocks: 89161
  Show dependency treegraph
Reported: 2012-08-20 18:10 PDT by Ryosuke Niwa
Modified: 2012-08-21 11:09 PDT (History)
4 users (show)

See Also:

Patch (15.46 KB, patch)
2012-08-20 18:11 PDT, Ryosuke Niwa
dpranke: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-08-20 18:10:00 PDT
Move free functions in test_expectations to TestExpectations class
Comment 1 Ryosuke Niwa 2012-08-20 18:11:07 PDT
Created attachment 159580 [details]
Comment 2 Dirk Pranke 2012-08-20 22:10:21 PDT
Comment on attachment 159580 [details]

I personally have nothing against free functions and think staticmethods tend to be a bad idea, but that is not the way adam and eric seemed to like things, so this is fine, too.

(I think the argument is that if the function is a static method, then you can more easily override it for testing/mocking purposes without introducing side effects).
Comment 3 WebKit Review Bot 2012-08-20 22:57:56 PDT
Comment on attachment 159580 [details]

Rejecting attachment 159580 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Auto-merging Tools/ChangeLog
CONFLICT (content): Merge conflict in Tools/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Reduce GradientAttributes object size

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13549243
Comment 4 Ryosuke Niwa 2012-08-21 11:09:49 PDT
Committed r126176: <http://trac.webkit.org/changeset/126176>