Move free functions in test_expectations to TestExpectations class
Created attachment 159580 [details] Patch
Comment on attachment 159580 [details] Patch I personally have nothing against free functions and think staticmethods tend to be a bad idea, but that is not the way adam and eric seemed to like things, so this is fine, too. (I think the argument is that if the function is a static method, then you can more easily override it for testing/mocking purposes without introducing side effects).
Comment on attachment 159580 [details] Patch Rejecting attachment 159580 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: .. Auto-merging Tools/ChangeLog CONFLICT (content): Merge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 Reduce GradientAttributes object size When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13549243
Committed r126176: <http://trac.webkit.org/changeset/126176>