Bug 94555 – REGRESSION(r126095): Breaks compilation of downstream WebWidget::paint implementations (Requested by jamesr on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/126095 broke the build:
Breaks compilation of downstream WebWidget::paint implementations (Requested by jamesr on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 159579 [details]
ROLLOUT of r126095

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[James Robinson]

Log:

FAILED: clang++ -MMD -MF obj/content/renderer/content_renderer.render_widget_fullscreen_pepper.o.d -DCONTENT_IMPLEMENTATION -DCHROMIUM_BUILD -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DSK_BUILD_NO_IMAGE_ENCODE -DSK_DEFERRED_CANVAS_USES_GPIPE=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DGR_AGGRESSIVE_SHADER_OPTS=1 -DHYPHEN_CHROME_CLIENT -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX -DPOSIX -DXML_STATIC -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/icu/public/i18n -I../../third_party/icu/public/common -I../.. -I../../third_party/khronos -Igen/content -I../../skia/config -I../../third_party/skia/src/core -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/gpu/gl -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/skia/include/utils/mac -I../../third_party/hyphen -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party/webrtc -I../../third_party/expat/files/lib -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/WebKit/Source/Platform/chromium -Igen/webcore_headers -I../../v8/include -I../../third_party/webrtc/modules/video_capture/main/interface -I../../third_party/webrtc/modules/interface -I../../third_party/webrtc/common_video/libyuv/include -I../../third_party/webrtc/system_wrappers/interface -I../../third_party/webrtc/video_engine/include -I../../third_party/webrtc/voice_engine/include -isysroot /Developer/SDKs/MacOSX10.6.sdk -O3 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-char-subscripts -Wno-unused-function -Wno-unnamed-type-template-args -Wno-c++11-extensions -Wno-covered-switch-default -Wexit-time-destructors -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/GPU_Mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations -Xclang -plugin-arg-find-bad-constructs -Xclang check-inner-classes -fcolor-diagnostics  -c ../../content/renderer/render_widget_fullscreen_pepper.cc -o obj/content/renderer/content_renderer.render_widget_fullscreen_pepper.o
../../content/renderer/render_widget_fullscreen_pepper.cc:111:16:error: '<anonymous namespace>::PepperWidget::paint' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  virtual void paint(WebCanvas* canvas, const WebRect& rect) {
               ^
../../third_party/WebKit/Source/WebKit/chromium/public/WebWidget.h:115:18: note: hidden overloaded virtual function 'WebKit::WebWidget::paint' declared here
    virtual void paint(WebCanvas*, const WebRect& viewPort, PaintOptions = ReadbackFromCompositorIfAvailable) { }
                 ^
1 error generated.

[Kenneth Russell]

Comment on attachment 159579 [details]
ROLLOUT of r126095

Clearing flags on attachment: 159579

Committed r126111: <http://trac.webkit.org/changeset/126111>

[Kenneth Russell]

All reviewed patches have been landed.  Closing bug.