Bug 94553 – Add mountain lion to perf-tests, layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Babak Shafiei]

Need to add mountain-lion to set of allowed port names so that perf-tests can run


http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%28Perf%29/builds/14/steps/perf-test/logs/stdio

Traceback (most recent call last):
  File "./Tools/Scripts/run-perf-tests", line 40, in <module>
    sys.exit(PerfTestsRunner().run())
  File "/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 67, in __init__
    self._port = self._host.port_factory.get(self._options.platform, self._options)
  File "/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 114, in get
    return cls(self._host, port_name, options=options, **kwargs)
  File "/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/mac.py", line 56, in __init__
    ApplePort.__init__(self, host, port_name, **kwargs)
  File "/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/apple.py", line 79, in __init__
    assert port_name in allowed_port_names, "%s is not in %s" % (port_name, allowed_port_names)
AssertionError: mac-mountainlion is not in ['mac-leopard', 'mac-snowleopard', 'mac-lion', 'mac', 'mac-future']

[Dirk Pranke]

Note that you can work around this at the moment by passing mac-future, but we do need to fix this. Reassigning to me; last I checked fixing this was more convoluted than I would've liked.

[Dirk Pranke]

Created attachment 159822 [details]
Patch

[Dirk Pranke]

Committed r126247: <http://trac.webkit.org/changeset/126247>