Bug 94553 - Add mountain lion to perf-tests, layout tests
Summary: Add mountain lion to perf-tests, layout tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
Depends on:
Reported: 2012-08-20 17:41 PDT by Babak Shafiei
Modified: 2012-08-21 18:45 PDT (History)
9 users (show)

See Also:

Patch (19.06 KB, patch)
2012-08-21 17:52 PDT, Dirk Pranke
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Babak Shafiei 2012-08-20 17:41:37 PDT
Need to add mountain-lion to set of allowed port names so that perf-tests can run


Traceback (most recent call last):
  File "./Tools/Scripts/run-perf-tests", line 40, in <module>
  File "/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 67, in __init__
    self._port = self._host.port_factory.get(self._options.platform, self._options)
  File "/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 114, in get
    return cls(self._host, port_name, options=options, **kwargs)
  File "/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/mac.py", line 56, in __init__
    ApplePort.__init__(self, host, port_name, **kwargs)
  File "/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/apple.py", line 79, in __init__
    assert port_name in allowed_port_names, "%s is not in %s" % (port_name, allowed_port_names)
AssertionError: mac-mountainlion is not in ['mac-leopard', 'mac-snowleopard', 'mac-lion', 'mac', 'mac-future']
Comment 1 Dirk Pranke 2012-08-20 22:03:53 PDT
Note that you can work around this at the moment by passing mac-future, but we do need to fix this. Reassigning to me; last I checked fixing this was more convoluted than I would've liked.
Comment 2 Dirk Pranke 2012-08-21 17:52:48 PDT
Created attachment 159822 [details]
Comment 3 Dirk Pranke 2012-08-21 18:45:33 PDT
Committed r126247: <http://trac.webkit.org/changeset/126247>