Bug 94550 - [chromium] Texture layer should not generate zero textureId quads
Summary: [chromium] Texture layer should not generate zero textureId quads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks: 93677
  Show dependency tree / graph
 
Reported: 2012-08-20 17:07 PDT by Alexandre Elias
Modified: 2012-08-20 19:35 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.90 KB, patch)
2012-08-20 17:12 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2012-08-20 17:07:57 PDT 
[chromium] Texture layer should not generate zero textureId quads
Comment 1 Alexandre Elias 2012-08-20 17:12:54 PDT 
Created attachment 159566 [details]
Patch
Comment 2 Dana Jansens 2012-08-20 17:17:14 PDT 
Comment on attachment 159566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159566&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:91
> +    m_externalTextureResource = 0;

I don't think you need this, m_externalTextureResource is cleared in didDraw. And we won't call didLoseContext in the middle of creating the quads for a frame right?
Comment 3 Adrienne Walker 2012-08-20 17:20:58 PDT 
Comment on attachment 159566 [details]
Patch

R=me.  I think clearing m_externalTextureResources is fine.  Thanks for fixing this bug.
Comment 4 WebKit Review Bot 2012-08-20 19:35:49 PDT 
Comment on attachment 159566 [details]
Patch

Clearing flags on attachment: 159566

Committed r126122: <http://trac.webkit.org/changeset/126122>
Comment 5 WebKit Review Bot 2012-08-20 19:35:53 PDT 
All reviewed patches have been landed.  Closing bug.