Bug 94545 - Cleanup TestExpectationParser.parse
Summary: Cleanup TestExpectationParser.parse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 89161
  Show dependency tree / graph
 
Reported: 2012-08-20 16:32 PDT by Ryosuke Niwa
Modified: 2012-08-20 22:57 PDT (History)
5 users (show)

See Also:

Attachments
Cleanup (11.22 KB, patch)
2012-08-20 16:39 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-08-20 16:32:49 PDT 
Cleanup TestExpectationParser.parse
Comment 1 Ryosuke Niwa 2012-08-20 16:39:14 PDT 
Created attachment 159560 [details]
Cleanup
Comment 2 Dirk Pranke 2012-08-20 22:08:02 PDT 
Comment on attachment 159560 [details]
Cleanup

So, the change looks more or less correct, but it's not obvious to me that it's better. Can you update the changelog to say why you think things are better (or just update the bug)? Maybe it'll make subsequent refactoring easier or something?
Comment 3 Ryosuke Niwa 2012-08-20 22:11:06 PDT 
(In reply to comment #2)
> (From update of attachment 159560 [details])
> So, the change looks more or less correct, but it's not obvious to me that it's better. Can you update the changelog to say why you think things are better (or just update the bug)? Maybe it'll make subsequent refactoring easier or something?

I'm trying to reduce the number of functions to make the subsequent refactoring easier. Also, the check for having both timeout and slow was done in _parse_line instead of _parse_modifiers where other modifier errors were generated.
Comment 4 Dirk Pranke 2012-08-20 22:12:37 PDT 
ok.
Comment 5 WebKit Review Bot 2012-08-20 22:57:00 PDT 
Comment on attachment 159560 [details]
Cleanup

Clearing flags on attachment: 159560

Committed r126135: <http://trac.webkit.org/changeset/126135>
Comment 6 WebKit Review Bot 2012-08-20 22:57:03 PDT 
All reviewed patches have been landed.  Closing bug.