RESOLVED FIXED 94542
[chromium] beef up test coverage of drawableContentRect and visibleLayerRect 
https://bugs.webkit.org/show_bug.cgi?id=94542
Summary [chromium] beef up test coverage of drawableContentRect and visibleLayerRect
Shawn Singh
Reported 2012-08-20 16:06:20 PDT
(1) as the bug title suggests (2) we had previously agreed to re-name drawableContentRect to "clippedRectInTargetSpace". I think this is a good time to do that (3) in a follow-up patch 94541, it is possible these two properties in LayerChromium/CCLayerImpl might be able to be merged =)
Attachments
Patch (20.29 KB, patch)
2012-08-28 23:23 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2012-08-28 23:23:51 PDT
Created attachment 161143 [details] Patch This patch is written assuming that 95253 lands first
Shawn Singh
Comment 2 2012-08-29 08:42:36 PDT
Just a clarification, it is expected that the linux bot will fail because the unit tests require 95235 to land first. I didn't mean for this patch to go through the bots yet, but it did =)
Adrienne Walker
Comment 3 2012-08-29 10:00:52 PDT
Comment on attachment 161143 [details] Patch R=me. All these tests look good, so I'll R+ this. However, I'd love to see some tests that involved a device scale or contentBounds != bounds, since those are typical edge cases that break.
Shawn Singh
Comment 4 2012-08-29 14:52:33 PDT
Comment on attachment 161143 [details] Patch Thanks for review! Looks like it may be a short while before I get around to making the high DPI tests, and the results I got from writing them are not quite what I expected. I think it's good for us to get coverage on these rects now, so I'll go ahead and put this through the cq, and I made a new bug https://bugs.webkit.org/show_bug.cgi?id=95384 to finish the high DPI ones.
WebKit Review Bot
Comment 5 2012-08-29 15:01:01 PDT
Comment on attachment 161143 [details] Patch Clearing flags on attachment: 161143 Committed r127055: <http://trac.webkit.org/changeset/127055>
WebKit Review Bot
Comment 6 2012-08-29 15:01:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.