RESOLVED FIXED 94511
CodeGeneratorInspector.py: Generate guards for type validators 
https://bugs.webkit.org/show_bug.cgi?id=94511
Summary CodeGeneratorInspector.py: Generate guards for type validators
Thiago Marcos P. Santos
Reported 2012-08-20 12:07:42 PDT
EFL Debug bots are broken after r126028. Release build looks like was unaffected, which makes me think we have something missing for NDEBUG flags.
Attachments
Patch (4.17 KB, patch)
2012-08-20 14:49 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Generated InspectorTypeBuilder.cpp before the patch. (18.78 KB, text/x-c++src)
2012-08-20 15:25 PDT, Thiago Marcos P. Santos 		no flags
Details
Generated InspectorTypeBuilder.cpp after the patch. (19.21 KB, text/x-c++src)
2012-08-20 15:25 PDT, Thiago Marcos P. Santos 		no flags
Details
Patch (4.59 KB, patch)
2012-08-21 00:36 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Generated InspectorTypeBuilder.cpp after the patch. (19.21 KB, text/x-c++src)
2012-08-21 00:38 PDT, Thiago Marcos P. Santos 		no flags
Details
Patch (4.88 KB, patch)
2012-08-21 00:41 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-08-20 12:23:57 PDT
The problem is not on bug 88973, but on the code generator. It was just exposed by the patch.
Thiago Marcos P. Santos
Comment 2 2012-08-20 14:49:26 PDT
Created attachment 159526 [details] Patch
Thiago Marcos P. Santos
Comment 3 2012-08-20 15:25:00 PDT
Created attachment 159534 [details] Generated InspectorTypeBuilder.cpp before the patch.
Thiago Marcos P. Santos
Comment 4 2012-08-20 15:25:31 PDT
Created attachment 159535 [details] Generated InspectorTypeBuilder.cpp after the patch.
Andrey Adaikin
Comment 5 2012-08-21 00:23:33 PDT
Yeah, thanks for fixing this!
Thiago Marcos P. Santos
Comment 6 2012-08-21 00:27:17 PDT
(In reply to comment #5) > Yeah, thanks for fixing this! Can you help me to find a reviewer for this patch? I have 2 debug bots broken since yesterday because of this regression.
Yury Semikhatsky
Comment 7 2012-08-21 00:29:10 PDT
Comment on attachment 159526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159526&action=review A couple of nits otherwise looks good. > Source/WebCore/inspector/CodeGeneratorInspector.py:931 > + if domain_guard: The closing guard should go right after "}" and be followed by "\n\n\n" to match the coding style when there is no guard. > Source/WebCore/inspector/CodeGeneratorInspector.py:1338 > + if domain_guard: Same here.
Thiago Marcos P. Santos
Comment 8 2012-08-21 00:35:01 PDT
Comment on attachment 159526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159526&action=review >> Source/WebCore/inspector/CodeGeneratorInspector.py:931 >> + if domain_guard: > > The closing guard should go right after "}" and be followed by "\n\n\n" to match the coding style when there is no guard. You probably meant after "}\n" and followed by "\n\n", right?
Thiago Marcos P. Santos
Comment 9 2012-08-21 00:36:15 PDT
Created attachment 159632 [details] Patch
Thiago Marcos P. Santos
Comment 10 2012-08-21 00:38:12 PDT
Created attachment 159633 [details] Generated InspectorTypeBuilder.cpp after the patch.
Thiago Marcos P. Santos
Comment 11 2012-08-21 00:41:58 PDT
Created attachment 159634 [details] Patch Added copyright notice.
WebKit Review Bot
Comment 12 2012-08-21 16:09:32 PDT
Comment on attachment 159634 [details] Patch Clearing flags on attachment: 159634 Committed r126206: <http://trac.webkit.org/changeset/126206>
WebKit Review Bot
Comment 13 2012-08-21 16:09:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.