EFL Debug bots are broken after r126028. Release build looks like was unaffected, which makes me think we have something missing for NDEBUG flags.
The problem is not on bug 88973, but on the code generator. It was just exposed by the patch.
Created attachment 159526 [details] Patch
Created attachment 159534 [details] Generated InspectorTypeBuilder.cpp before the patch.
Created attachment 159535 [details] Generated InspectorTypeBuilder.cpp after the patch.
Yeah, thanks for fixing this!
(In reply to comment #5) > Yeah, thanks for fixing this! Can you help me to find a reviewer for this patch? I have 2 debug bots broken since yesterday because of this regression.
Comment on attachment 159526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159526&action=review A couple of nits otherwise looks good. > Source/WebCore/inspector/CodeGeneratorInspector.py:931 > + if domain_guard: The closing guard should go right after "}" and be followed by "\n\n\n" to match the coding style when there is no guard. > Source/WebCore/inspector/CodeGeneratorInspector.py:1338 > + if domain_guard: Same here.
Comment on attachment 159526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159526&action=review >> Source/WebCore/inspector/CodeGeneratorInspector.py:931 >> + if domain_guard: > > The closing guard should go right after "}" and be followed by "\n\n\n" to match the coding style when there is no guard. You probably meant after "}\n" and followed by "\n\n", right?
Created attachment 159632 [details] Patch
Created attachment 159633 [details] Generated InspectorTypeBuilder.cpp after the patch.
Created attachment 159634 [details] Patch Added copyright notice.
Comment on attachment 159634 [details] Patch Clearing flags on attachment: 159634 Committed r126206: <http://trac.webkit.org/changeset/126206>
All reviewed patches have been landed. Closing bug.