Bug 94506 - Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
Summary: Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-20 11:04 PDT by Brady Eidson
Modified: 2012-08-20 11:20 PDT (History)
5 users (show)

See Also:


Attachments
Proposed fix (2.92 KB, patch)
2012-08-20 11:08 PDT, Brady Eidson
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-08-20 11:04:44 PDT
Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.

Seemingly randomly the WK2 bots are aborting due to 500+ failures.  Figuring out why is covered by https://bugs.webkit.org/show_bug.cgi?id=94505

When you try to reproduce this locally you'll often see about ~700 flakey tests but they don't reproduce the flakiness on the retry.

Therefore, even when you get the 500+ failures once, you still get actual information from the test run after they pass the retry.

Therefore if we *didn't* bail early on the bots and instead re-ran the flaky tests then we'd actually be getting real information while we wait for 94505 to be resolved.
Comment 1 Brady Eidson 2012-08-20 11:08:23 PDT
Created attachment 159475 [details]
Proposed fix

I don't actually know how to test changes to the buildbot infrastructure.  I'll deferring to experts on whether or not that's possible and/or how to verify this change is sane.
Comment 2 Dirk Pranke 2012-08-20 11:10:53 PDT
Comment on attachment 159475 [details]
Proposed fix

looks fine. I wouldn't worry about testing this, since it'll show up on the bot and presumably we can back this change out once things are fixed.
Comment 3 Brady Eidson 2012-08-20 11:20:49 PDT
Landed in http://trac.webkit.org/changeset/126044