Bug 94482 – [BlackBerry] Persist cookies not from atexit() but the new onThreadFinished()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Jakob Petsovits]

Our port is making some changes to shut down all threads correctly when the process exits. We're therefore introducing a new onThreadFinished() virtual for MessageClients, which is nicer than setting an atexit() handler from within WebKit. Here's the patch to make use of that functionality in WebKit.

[Jakob Petsovits]

Created attachment 159428 [details]
Patch

[Yong Li]

Comment on attachment 159428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159428&action=review

> Source/WebCore/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new functionality, no new tests.

need some description between these 2 lines :)

> Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:89
> +    CookieLog("CookieManager - flushing cookies to backingStore...");

should be cookieLog() according to webkit style?

[Jakob Petsovits]

Created attachment 159481 [details]
Patch

[Jakob Petsovits]

I talked to Yong and he revoked his wish for renaming CookieLog(), as it affects a multitude of other lines in the same file and consequently would expand the scope of this patch significantly.

[WebKit Review Bot]

Comment on attachment 159481 [details]
Patch

Clearing flags on attachment: 159481

Committed r126053: <http://trac.webkit.org/changeset/126053>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.