Bug 94468 - [Qt] Custom tap-highlight-color renders fully opaque
Summary: [Qt] Custom tap-highlight-color renders fully opaque
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-20 05:13 PDT by Allan Sandfeld Jensen
Modified: 2012-08-20 08:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.30 KB, patch)
2012-08-20 06:25 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-08-20 05:13:38 PDT 
Observed on the webpage http://heltnormalt.dk/striben, when tap clicking any link, the link will be obscured by pink opaque overlay.

The tap highlight color has been configured as:
a:link { -webkit-tap-highlight-color: #FF5E99; }

Which means it has been declared fully opaque, unfortunately that is not how Android, N9 or iPhone renders it as far as I can tell.

I am not sure what the right solution is, but I am leaning towards redefining defaultTapHighlightColor in RenderTheme.h from 0x33000000 to 0x66000000, and always start with the tap-highlight being at most 50% transparent. Apparently N9 defines the defaultTapHighlightColor to 0x7F000000, Android to 0x6633b5e5 and iPhone to 0x4D1A1A1A, so an alpha value of 0x66 would also fit in better with actually used defaults.
Comment 1 Kenneth Rohde Christiansen 2012-08-20 06:06:03 PDT 
Ah sounds good. Probably good to leave a comment next to the value
Comment 2 Allan Sandfeld Jensen 2012-08-20 06:25:51 PDT 
Created attachment 159410 [details]
Patch
Comment 3 WebKit Review Bot 2012-08-20 08:18:33 PDT 
Comment on attachment 159410 [details]
Patch

Clearing flags on attachment: 159410

Committed r126031: <http://trac.webkit.org/changeset/126031>
Comment 4 WebKit Review Bot 2012-08-20 08:18:37 PDT 
All reviewed patches have been landed.  Closing bug.