Bug 94459 - [V8] Move clearForClose() and clearForNavigation() from V8Proxy to ScriptController
Summary: [V8] Move clearForClose() and clearForNavigation() from V8Proxy to ScriptCont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 85330
  Show dependency tree / graph
 
Reported: 2012-08-20 02:27 PDT by Kentaro Hara
Modified: 2012-08-20 16:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.94 KB, patch)
2012-08-20 02:32 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-20 02:27:19 PDT 
To kill V8Proxy, we can move clearForClose() and clearForNavigation() from V8Proxy to ScriptController.
Comment 1 Kentaro Hara 2012-08-20 02:32:39 PDT 
Created attachment 159379 [details]
Patch
Comment 2 Adam Barth 2012-08-20 11:29:46 PDT 
Comment on attachment 159379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159379&action=review

> Source/WebCore/bindings/v8/ScriptController.cpp:156
> +    m_proxy->isolatedWorlds().clear();
> +    m_proxy->isolatedWorldSecurityOrigins().clear();

This is a bit odd, but these functions already have FIXME comments, so I take it that this is a temporary measure.
Comment 3 Kentaro Hara 2012-08-20 14:58:06 PDT 
(In reply to comment #2)
> > +    m_proxy->isolatedWorlds().clear();
> > +    m_proxy->isolatedWorldSecurityOrigins().clear();
> 
> This is a bit odd, but these functions already have FIXME comments, so I take it that this is a temporary measure.

Yes, these will be removed in this week.
Comment 4 WebKit Review Bot 2012-08-20 16:18:33 PDT 
Comment on attachment 159379 [details]
Patch

Clearing flags on attachment: 159379

Committed r126086: <http://trac.webkit.org/changeset/126086>
Comment 5 WebKit Review Bot 2012-08-20 16:18:37 PDT 
All reviewed patches have been landed.  Closing bug.