Bug 94457 - Web Inspector: Drop dimmed crumb handling
Summary: Web Inspector: Drop dimmed crumb handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Taiju Tsuiki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-20 02:06 PDT by Taiju Tsuiki
Modified: 2012-11-07 22:50 PST (History)
11 users (show)

See Also:


Attachments
Patch (4.56 KB, patch)
2012-08-20 02:07 PDT, Taiju Tsuiki
vsevik: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Taiju Tsuiki 2012-08-20 02:06:19 PDT
In Breadcrumbs of ElementsPanel, we skip DOCUMENT_NODE crumb and mark rootDOMNode as "dimmed".
But I think, rootDOMNode is always document node and is skipped.

So, "dimmed" node handling looks dead code.
Can we drop it as a cleanup?
Comment 1 Taiju Tsuiki 2012-08-20 02:07:54 PDT
Created attachment 159371 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-21 15:06:14 PDT
Comment on attachment 159371 [details]
Patch

Rejecting attachment 159371 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ceeded at 680 (offset 1 line).
Hunk #4 succeeded at 897 (offset 1 line).
Hunk #5 succeeded at 908 (offset 1 line).
patching file Source/WebCore/inspector/front-end/elementsPanel.css
Hunk #1 FAILED at 97.
Hunk #2 FAILED at 130.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/inspector/front-end/elementsPanel.css.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Vsevolod V..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13559035
Comment 3 Vsevolod Vlasov 2012-11-07 22:50:01 PST
Landed: http://trac.webkit.org/changeset/133852