RESOLVED FIXED 94457
Web Inspector: Drop dimmed crumb handling 
https://bugs.webkit.org/show_bug.cgi?id=94457
Summary Web Inspector: Drop dimmed crumb handling
Taiju Tsuiki
Reported 2012-08-20 02:06:19 PDT
In Breadcrumbs of ElementsPanel, we skip DOCUMENT_NODE crumb and mark rootDOMNode as "dimmed". But I think, rootDOMNode is always document node and is skipped. So, "dimmed" node handling looks dead code. Can we drop it as a cleanup?
Attachments
Patch (4.56 KB, patch)
2012-08-20 02:07 PDT, Taiju Tsuiki 		vsevik: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Taiju Tsuiki
Comment 1 2012-08-20 02:07:54 PDT
Created attachment 159371 [details] Patch
WebKit Review Bot
Comment 2 2012-08-21 15:06:14 PDT
Comment on attachment 159371 [details] Patch Rejecting attachment 159371 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ceeded at 680 (offset 1 line). Hunk #4 succeeded at 897 (offset 1 line). Hunk #5 succeeded at 908 (offset 1 line). patching file Source/WebCore/inspector/front-end/elementsPanel.css Hunk #1 FAILED at 97. Hunk #2 FAILED at 130. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/inspector/front-end/elementsPanel.css.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Vsevolod V..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13559035
Vsevolod Vlasov
Comment 3 2012-11-07 22:50:01 PST
Landed: http://trac.webkit.org/changeset/133852
Note You need to log in before you can comment on or make changes to this bug.