We can move collectGarbage() from ScriptController to V8GCController. Also we can remove ScriptController::lowMemoryNotification() since it is not used at all.
Created attachment 159368 [details] Patch
Comment on attachment 159368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159368&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:534 > +void V8GCController::collectGarbage() It's a bit strange that collectGarbageIfNecessary is so different from collectGarbage. > Source/WebCore/bindings/v8/V8GCController.cpp:538 > + v8::Persistent<v8::Context> v8Context = v8::Context::New(); v8Context -> context
Committed r126098: <http://trac.webkit.org/changeset/126098>
(In reply to comment #2) > > Source/WebCore/bindings/v8/V8GCController.cpp:534 > > +void V8GCController::collectGarbage() > > It's a bit strange that collectGarbageIfNecessary is so different from collectGarbage. collectGarbage() always collects garbage. collectGarbageIfNecessary() just sends an idle notification to V8, which is just a hint for V8 to trigger GC. Maybe can we rename collectGarbageIfNecessary() to hintForCollectGarbage()? > > Source/WebCore/bindings/v8/V8GCController.cpp:538 > > + v8::Persistent<v8::Context> v8Context = v8::Context::New(); > > v8Context -> context Done.
> hintForCollectGarbage Ok. I think that's the name you had before I asked you to change it. :)
Reopening to attach new patch.
Created attachment 159568 [details] Patch
Comment on attachment 159568 [details] Patch Clearing flags on attachment: 159568 Committed r126123: <http://trac.webkit.org/changeset/126123>
All reviewed patches have been landed. Closing bug.