Bug 94455 – [V8] Move collectGarbage() from ScriptController to V8GCController

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

We can move collectGarbage() from ScriptController to V8GCController. Also we can remove ScriptController::lowMemoryNotification() since it is not used at all.

[Kentaro Hara]

Created attachment 159368 [details]
Patch

[Adam Barth]

Comment on attachment 159368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159368&action=review

> Source/WebCore/bindings/v8/V8GCController.cpp:534
> +void V8GCController::collectGarbage()

It's a bit strange that collectGarbageIfNecessary is so different from collectGarbage.

> Source/WebCore/bindings/v8/V8GCController.cpp:538
> +    v8::Persistent<v8::Context> v8Context = v8::Context::New();

v8Context -> context

[Kentaro Hara]

Committed r126098: <http://trac.webkit.org/changeset/126098>

[Kentaro Hara]

(In reply to comment #2)
> > Source/WebCore/bindings/v8/V8GCController.cpp:534
> > +void V8GCController::collectGarbage()
> 
> It's a bit strange that collectGarbageIfNecessary is so different from collectGarbage.

collectGarbage() always collects garbage. collectGarbageIfNecessary() just sends an idle notification to V8, which is just a hint for V8 to trigger GC. Maybe can we rename collectGarbageIfNecessary() to hintForCollectGarbage()?

> > Source/WebCore/bindings/v8/V8GCController.cpp:538
> > +    v8::Persistent<v8::Context> v8Context = v8::Context::New();
> 
> v8Context -> context

Done.

[Adam Barth]

> hintForCollectGarbage

Ok.  I think that's the name you had before I asked you to change it.  :)

[Kentaro Hara]

Reopening to attach new patch.

[Kentaro Hara]

Created attachment 159568 [details]
Patch

[WebKit Review Bot]

Comment on attachment 159568 [details]
Patch

Clearing flags on attachment: 159568

Committed r126123: <http://trac.webkit.org/changeset/126123>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.